-
Notifications
You must be signed in to change notification settings - Fork 9.6k
misc(proto): add ConfigSettings fields #15616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Probably good to incentivize stability, but this means we can't change these types later (e.g. string to a struct or whatever), just retire them and pick a new name, right? Also does it matter if e.g. |
|
lets drop auditMode/gatherMode for now |
…s' into proto-configsettings
Co-authored-by: Connor Clark <[email protected]>
…s' into proto-configsettings
fixes #15193
I adapted the suggested syntax quite a bit. But... it's now happy for python, go, and C++ protobuf handling.
with the additions we can delete some of the hax in proto-processors (which is used in LR)