Skip to content

[Tab] Add support for tones #697

@infernova

Description

@infernova

Prerequisites

Proposal

Expand the sgds-tab visual library by implementing tone variants. I referenced the tones used by sgds-spinner to get a rough gauge for which tone would fit SGDS' current visual vocabulary.

New Tones

Neutral

Image

Inverse

Image

Fixed Dark

Image

Fixed Light

Image

Code Implementation

The proposed code implementation is quite complex as the CSS has to account for two variants as well as hover/focus states so it would be easier to review if I just submitted a PR

Motivation and context

In Product Portal currently, we have a need to implement sgds-tab using a fixed-dark/inverse tone but that is not implemented so we substituted sgds-tab with sgds-button. However, sgds-button has some undesired CSS interactions when users click on the tab.

Current implementation using sgds-button

Image

CSS issue on click

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions