You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expand the sgds-tab visual library by implementing tone variants. I referenced the tones used by sgds-spinner to get a rough gauge for which tone would fit SGDS' current visual vocabulary.
New Tones
Neutral
Inverse
Fixed Dark
Fixed Light
Code Implementation
The proposed code implementation is quite complex as the CSS has to account for two variants as well as hover/focus states so it would be easier to review if I just submitted a PR
Motivation and context
In Product Portal currently, we have a need to implement sgds-tab using a fixed-dark/inverse tone but that is not implemented so we substituted sgds-tab with sgds-button. However, sgds-button has some undesired CSS interactions when users click on the tab.
Prerequisites
Proposal
Expand the
sgds-tabvisual library by implementingtonevariants. I referenced the tones used bysgds-spinnerto get a rough gauge for whichtonewould fit SGDS' current visual vocabulary.New Tones
Neutral
Inverse
Fixed Dark
Fixed Light
Code Implementation
The proposed code implementation is quite complex as the CSS has to account for two
variantsas well ashover/focusstates so it would be easier to review if I just submitted a PRMotivation and context
In Product Portal currently, we have a need to implement
sgds-tabusing afixed-dark/inversetone but that is not implemented so we substitutedsgds-tabwithsgds-button. However,sgds-buttonhas some undesired CSS interactions when users click on the tab.Current implementation using
sgds-buttonCSS issue on click