Skip to content

Commit a8f1fc0

Browse files
committed
fix: comments
Signed-off-by: Dennis Zhuang <[email protected]>
1 parent e1e04e9 commit a8f1fc0

File tree

8 files changed

+10
-6
lines changed

8 files changed

+10
-6
lines changed

tests/cases/standalone/common/aggregate/approx_distinct.result

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
-- Migrated from DuckDB test: test/sql/aggregate/aggregates/test_approximate_distinct_count.test
2-
-- Test approx_count_distinct operator
2+
-- Test approx_distinct function
33
-- Basic tests
44
SELECT APPROX_DISTINCT(1);
55

tests/cases/standalone/common/aggregate/approx_distinct.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
-- Migrated from DuckDB test: test/sql/aggregate/aggregates/test_approximate_distinct_count.test
2-
-- Test approx_count_distinct operator
2+
-- Test approx_distinct function
33

44
-- Basic tests
55
SELECT APPROX_DISTINCT(1);

tests/cases/standalone/common/aggregate/approx_percentile_cont.result

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
-- Migrated from DuckDB test: test/sql/aggregate/aggregates/test_approx_quantile.test
2-
-- Test APPROX_QUANTILE function
2+
-- Test approx_percentile_cont function instead of approx_quantile
33
-- Test basic approximate quantile
44
CREATE TABLE approx_test(i INTEGER, ts TIMESTAMP TIME INDEX);
55

tests/cases/standalone/common/aggregate/approx_percentile_cont.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
-- Migrated from DuckDB test: test/sql/aggregate/aggregates/test_approx_quantile.test
2-
-- Test APPROX_QUANTILE function
2+
-- Test approx_percentile_cont function instead of approx_quantile
33

44
-- Test basic approximate quantile
55
CREATE TABLE approx_test(i INTEGER, ts TIMESTAMP TIME INDEX);

tests/cases/standalone/common/aggregate/avg.result

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ SELECT AVG(i), AVG(j) FROM vals;
8989
+-------------+-------------+
9090

9191
-- FIXME(dennis): AVG(DISTINCT) not supported
92+
-- https://github.com/apache/datafusion/issues/2408
9293
-- SELECT AVG(DISTINCT i), AVG(DISTINCT j) FROM vals;
9394
-- cleanup
9495
DROP TABLE integers;

tests/cases/standalone/common/aggregate/avg.sql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ INSERT INTO vals VALUES (1, 1.5, 1000), (2, 2.5, 2000), (3, 3.5, 3000), (NULL, N
3737
SELECT AVG(i), AVG(j) FROM vals;
3838

3939
-- FIXME(dennis): AVG(DISTINCT) not supported
40+
-- https://github.com/apache/datafusion/issues/2408
4041
-- SELECT AVG(DISTINCT i), AVG(DISTINCT j) FROM vals;
4142

4243
-- cleanup

tests/cases/standalone/common/aggregate/corr.result

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ SELECT corr(NULL,NULL);
99
| |
1010
+-----------------+
1111

12-
-- Single value returns NaN
12+
-- Single value returns NULL
13+
-- FIXME(dennis): datafusion returns 0.0 here, should be NULL
1314
SELECT corr(1,1);
1415

1516
+-------------------------+

tests/cases/standalone/common/aggregate/corr.sql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
-- Corner cases
55
SELECT corr(NULL,NULL);
66

7-
-- Single value returns NaN
7+
-- Single value returns NULL
8+
-- FIXME(dennis): datafusion returns 0.0 here, should be NULL
89
SELECT corr(1,1);
910

1011
-- Test with table

0 commit comments

Comments
 (0)