Using variables fails when text property contains more than just the variable

[oradke]

Perform all steps below and tick them with [x]

• [X ] Check the related part of the Documentation
• [ X] Update openHASP to the latest version
• [X ] Reproduce the issue and describe all steps

Describe the bug

Using variables fails when text property contains more than just the variable

To Reproduce

{"page":0,"obj":"label","id":110,"x":410,"y":3,"w":390,"h":40,"text":"%hostname%"}

returns "plate6"

{"page":0,"obj":"label","id":110,"x":410,"y":3,"w":390,"h":40,"text":"%hostname% (%ip%)"}

returns "%hostname% (%ip%)"

Expected behavior

I would expect that all variable names are replaced by the current values, so that
"%hostname% (%ip%)"
becomes
"plate6 (192.168.X.X)"

[fvanroie]

This is not a bug, but that's how it is implemented. openHASP doesn't "evaluate" the string, it only checks and swaps the whole text if the %variable% matches the text...

If you want a real evaluation of the text containing multiple variables, please post a PR for this new feature.
As a workaround, please use two text fields, one for each variable.

[oradke]

OK, I'll look into that.

In the meantime, can I (or someone else) add a note to the documentation that variables can only be used the way you described??

[oradke]

Would this work? I can't setup a test environment right now. Perhaps someone can give it a try? Goes into src\hasp\hasp_attribute_helper.h at line 506.

static void my_label_set_text(lv_obj_t* label, const char* text)
{
    if(!text || !label) return;

    std::string result(text);

    // Helper to replace tags only if not preceded by '\'
    auto safe_replace = [](std::string& str, const std::string& tag, const char* replacement) {
        size_t pos = 0;
        while((pos = str.find(tag, pos)) != std::string::npos) {
            if(pos == 0 || str[pos - 1] != '\\') {
                str.replace(pos, tag.length(), replacement);
                pos += strlen(replacement);
            } else {
                // Remove the escape character '\'
                str.erase(pos - 1, 1);
                pos += tag.length() - 1;
            }
        }
    };

    safe_replace(result, "%mac%", haspDevice.get_hardware_id());

#if HASP_USE_WIFI > 0
    safe_replace(result, "%ssid%", wifi_get_ssid());
    safe_replace(result, "%ip%", wifi_get_ip_address());
#endif

    safe_replace(result, "%hostname%", haspDevice.get_hostname());
    safe_replace(result, "%model%", haspDevice.get_model());
    safe_replace(result, "%version%", haspDevice.get_version());

    lv_label_set_text(label, result.c_str());
}

[fvanroie]

In the meantime, can I (or someone else) add a note to the documentation that variables can only be used the way you described??

Each page on the website should have an icon in the top right corner that says "Edit this page". You can use that to submit updates to the documentation.

[oradke]

This is not a bug, but that's how it is implemented. openHASP doesn't "evaluate" the string, it only checks and swaps the whole text if the %variable% matches the text...

If you want a real evaluation of the text containing multiple variables, please post a PR for this new feature. As a workaround, please use two text fields, one for each variable.

PR submitted: #949