feat: fix double registration bug

Dino-Kupinic · Dino-Kupinic · commit 0427ea4d5a85 · 2026-03-11T22:01:32.000+01:00
diff --git a/apps/api/supabase/migrations/20260311101500_team_registration_unique.sql b/apps/api/supabase/migrations/20260311101500_team_registration_unique.sql
@@ -0,0 +1,21 @@
+WITH ranked_teams AS (
+  SELECT
+    t.id,
+    row_number() OVER (
+      PARTITION BY t.registration_id
+      ORDER BY count(p.id) DESC, t.created_at ASC, t.id ASC
+    ) AS row_num
+  FROM public.team AS t
+  LEFT JOIN public.player AS p
+    ON p.team_id = t.id
+  GROUP BY t.id
+)
+DELETE FROM public.team
+WHERE id IN (
+  SELECT id
+  FROM ranked_teams
+  WHERE row_num > 1
+);
+
+ALTER TABLE public.team
+  ADD CONSTRAINT team_registration_id_key UNIQUE (registration_id);
diff --git a/apps/viewer/app/components/registration/forms/BaseForm.vue b/apps/viewer/app/components/registration/forms/BaseForm.vue
@@ -98,8 +98,10 @@ async function submitForm() {
         message: err.message,
       }))
       form.value?.setErrors(formErrors)
+      return false
     } else {
       model.value = state.players
+      return true
     }
   } catch (error) {
     throw createError({
diff --git a/apps/viewer/app/pages/(tournament)/registrations/[id].vue b/apps/viewer/app/pages/(tournament)/registrations/[id].vue
@@ -132,9 +132,11 @@ const generatePDF = async () => {
 
     downloadPdf(response)
   } catch (error) {
+    const err = error as Error
+
     throw createError({
       message: "Error generating PDF",
-      data: error.message,
+      data: err.message,
     })
   } finally {
     isGeneratingPdf.value = false
@@ -163,9 +165,19 @@ const playerCount = computed(() => {
 })
 
 const formRef = useTemplateRef("formRef")
+const isSubmitting = ref(false)
+
 const submit = async () => {
+  if (isSubmitting.value) {
+    return
+  }
+
   // @ts-ignore build error
-  formRef.value?.$.exposed?.submitForm()
+  const isValid = await formRef.value?.$.exposed?.submitForm()
+  if (!isValid) {
+    return
+  }
+
   const payload = {
     formPlayers: formPlayers.value,
     logo: selectedLogo.value,
@@ -175,6 +187,8 @@ const submit = async () => {
   }
 
   try {
+    isSubmitting.value = true
+
     await $fetch("/api/teams/create", {
       method: "POST",
       body: payload,
@@ -189,6 +203,8 @@ const submit = async () => {
     throw createError({
       statusMessage: err.message,
     })
+  } finally {
+    isSubmitting.value = false
   }
 }
 </script>
@@ -345,6 +361,8 @@ const submit = async () => {
         />
         <UButton
           label="Anmelden"
+          :disabled="isSubmitting"
+          :loading="isSubmitting"
           @click="submit"
           block
           size="lg"
diff --git a/apps/viewer/server/api/teams/create/index.post.ts b/apps/viewer/server/api/teams/create/index.post.ts
@@ -19,13 +19,33 @@ export default defineEventHandler(async (event) => {
   const { formPlayers, logo, logo_variant, registration, tournament } =
     await readBody<Body>(event)
 
-  if (!formPlayers || !logo || !registration) {
+  if (!formPlayers || !logo || !registration || !tournament) {
     throw createError({
       statusCode: 400,
       statusMessage: "Missing data fields",
     })
   }
 
+  const { data: currentRegistration, error: registrationError } = await supabase
+    .from("registration")
+    .select("id, status")
+    .eq("id", registration.id)
+    .single()
+
+  if (registrationError) {
+    throw createError({
+      statusCode: 500,
+      statusMessage: registrationError.message,
+    })
+  }
+
+  if (currentRegistration.status !== "Ausstehend") {
+    throw createError({
+      statusCode: 409,
+      statusMessage: "Die Anmeldung wurde bereits abgesendet.",
+    })
+  }
+
   const { data: groups, error: groupError } = await supabase
     .from("group")
     .select("*")
@@ -80,6 +100,13 @@ export default defineEventHandler(async (event) => {
   const { data, error } = await supabase.from("team").insert(team).select()
 
   if (error) {
+    if (error.code === "23505") {
+      throw createError({
+        statusCode: 409,
+        statusMessage: "Die Anmeldung wurde bereits abgesendet.",
+      })
+    }
+
     throw createError({
       statusCode: 500,
       statusMessage: error.message,
diff --git a/apps/viewer/server/api/teams/query/find-by-registration/[id].get.ts b/apps/viewer/server/api/teams/query/find-by-registration/[id].get.ts
@@ -13,7 +13,9 @@ export default defineEventHandler(async (event) => {
     .from("team")
     .select("*")
     .eq("registration_id", id)
-    .single()
+    .order("created_at", { ascending: true })
+    .limit(1)
+    .maybeSingle()
 
   return data
 })
