[ffigen] Pass destructor counter to getNode to verify destruction

Author: Hassnaa9

pkgs/ffigen/test/native_cpp_test/memory_edge_cases.cpp

@@ -21,8 +21,8 @@ int NodeManager::foo(Node* node) {
     return node->getValue();
 }
 
-Node* NodeManager::getNode() {
-    return new Node(100, nullptr);
+Node* NodeManager::getNode(int value, int* destructorCounter) {
+    return new Node(value, destructorCounter);
 }
 
 

pkgs/ffigen/test/native_cpp_test/memory_edge_cases.h

@@ -18,7 +18,7 @@ class NodeManager {
 public:
     NodeManager();
     int foo(Node* node);
-    Node* getNode();
+    Node* getNode(int value, int* destructorCounter);
     Node* newNode(int value, int* destructorCounter);
     Node* getSingletonNode(int value, int* destructorCounter);
     int getValue(Node* node);

pkgs/ffigen/test/native_cpp_test/memory_edge_cases_bindings.dart

@@ -230,12 +230,14 @@ class NodeManager implements ffi.Finalizable {
     return _NodeManager_foo(_ptr, node._ptr);
   }
 
-  Node getNode() {
+  Node getNode(int value, ffi.Pointer<ffi.Int> destructorCounter) {
     if (_ptr == ffi.nullptr) {
       throw StateError('This object has already been disposed.');
     }
 
-    return Node.fromPointer(_NodeManager_getNode(_ptr));
+    return Node.fromPointer(
+      _NodeManager_getNode(_ptr, value, destructorCounter),
+    );
   }
 
   Node newNode(int value, ffi.Pointer<ffi.Int> destructorCounter) {
@@ -305,10 +307,18 @@ external int _NodeManager_foo(
   ffi.Pointer<ffi.Void> node,
 );
 
-@ffi.Native<ffi.Pointer<ffi.Void> Function(ffi.Pointer<ffi.Void>)>(
-  symbol: 'NodeManager_getNode',
-)
-external ffi.Pointer<ffi.Void> _NodeManager_getNode(ffi.Pointer<ffi.Void> self);
+@ffi.Native<
+  ffi.Pointer<ffi.Void> Function(
+    ffi.Pointer<ffi.Void>,
+    ffi.Int,
+    ffi.Pointer<ffi.Int>,
+  )
+>(symbol: 'NodeManager_getNode')
+external ffi.Pointer<ffi.Void> _NodeManager_getNode(
+  ffi.Pointer<ffi.Void> self,
+  int value,
+  ffi.Pointer<ffi.Int> destructorCounter,
+);
 
 @ffi.Native<
   ffi.Pointer<ffi.Void> Function(

pkgs/ffigen/test/native_cpp_test/memory_edge_cases_bindings.dart.cpp

@@ -28,8 +28,8 @@ FFIGEN_EXPORT int NodeManager_foo(NodeManager* self, Node* node) {
   return self->foo(node);
 }
 
-FFIGEN_EXPORT Node* NodeManager_getNode(NodeManager* self) {
-  return self->getNode();
+FFIGEN_EXPORT Node* NodeManager_getNode(NodeManager* self, int value, int * destructorCounter) {
+  return self->getNode(value, destructorCounter);
 }
 
 FFIGEN_EXPORT Node* NodeManager_newNode(NodeManager* self, int value, int * destructorCounter) {

pkgs/ffigen/test/native_cpp_test/memory_edge_cases_test.dart

@@ -69,18 +69,23 @@ void main() {
 
     test('getNode() returns unowned pointer by default', () {
       final manager = NodeManager();
-      final node = manager.getNode();
+      final node = manager.getNode(100, nullptr);
       expect(node.getValue(), 100);
 
       // Wrapper is unowned by default, releaseOwnership throws StateError.
       expect(node.releaseOwnership, throwsStateError);
     });
 
     test('getNode() can take ownership via retainOwnership()', () {
+      final counter = calloc<Int32>()..value = 0;
       final manager = NodeManager();
-      final node = manager.getNode()..retainOwnership();
+      final node = manager.getNode(100, counter.cast())..retainOwnership();
       expect(node.getValue(), 100);
+      expect(counter.value, 0);
+
       node.dispose();
+      expect(counter.value, 1);
+      calloc.free(counter);
     });
 
     test('newNode() returns unowned by default, counter stays 0', () {