fix(client): resolve serialization issue with unions and enums

Author: stainless-app[bot]

src/Core/Attributes/Required.php

@@ -25,9 +25,6 @@ class Required
 
     public readonly bool $nullable;
 
-    /** @var array<string,Converter> */
-    private static array $enumConverters = [];
-
     /**
      * @param class-string<ConverterSource>|Converter|string|null $type
      * @param class-string<\BackedEnum>|Converter|null            $enum
@@ -52,24 +49,12 @@ public function __construct(
             $type ??= new MapOf($map);
         }
         if (null !== $enum) {
-            $type ??= $enum instanceof Converter ? $enum : self::enumConverter($enum);
+            $type ??= $enum instanceof Converter ? $enum : EnumOf::fromBackedEnum($enum);
         }
 
         $this->apiName = $apiName;
         $this->type = $type;
         $this->optional = false;
         $this->nullable = $nullable;
     }
-
-    /** @property class-string<\BackedEnum> $enum */
-    private static function enumConverter(string $enum): Converter
-    {
-        if (!isset(self::$enumConverters[$enum])) {
-            // @phpstan-ignore-next-line argument.type
-            $converter = new EnumOf(array_column($enum::cases(), column_key: 'value'));
-            self::$enumConverters[$enum] = $converter;
-        }
-
-        return self::$enumConverters[$enum];
-    }
 }

src/Core/Conversion.php

@@ -8,6 +8,7 @@
 use HubSpotSDK\Core\Conversion\Contracts\Converter;
 use HubSpotSDK\Core\Conversion\Contracts\ConverterSource;
 use HubSpotSDK\Core\Conversion\DumpState;
+use HubSpotSDK\Core\Conversion\EnumOf;
 
 /**
  * @internal
@@ -65,6 +66,13 @@ public static function coerce(Converter|ConverterSource|string $target, mixed $v
             return $target->coerce($value, state: $state);
         }
 
+        // BackedEnum class-name targets: wrap in EnumOf so enum values are scored
+        // against the enum's cases. Without this, tryConvert's default case scores
+        // any class-name target as `no`, even when the value is a valid enum member.
+        if (is_a($target, class: \BackedEnum::class, allow_string: true)) {
+            return EnumOf::fromBackedEnum($target)->coerce($value, state: $state);
+        }
+
         return self::tryConvert($target, value: $value, state: $state);
     }
 
@@ -78,6 +86,13 @@ public static function dump(Converter|ConverterSource|string $target, mixed $val
             return $target::converter()->dump($value, state: $state);
         }
 
+        // BackedEnum class-name targets: wrap in EnumOf so enum values are scored
+        // against the enum's cases. Without this, tryConvert's default case scores
+        // any class-name target as `no`, even when the value is a valid enum member.
+        if (is_a($target, class: \BackedEnum::class, allow_string: true)) {
+            return EnumOf::fromBackedEnum($target)->dump($value, state: $state);
+        }
+
         self::tryConvert($target, value: $value, state: $state);
 
         return self::dump_unknown($value, state: $state);

src/Core/Conversion/EnumOf.php

@@ -14,6 +14,9 @@ final class EnumOf implements Converter
 {
     private readonly string $type;
 
+    /** @var array<class-string<\BackedEnum>, self> */
+    private static array $cache = [];
+
     /**
      * @param list<bool|float|int|string|null> $members
      */
@@ -26,6 +29,13 @@ public function __construct(private readonly array $members)
         $this->type = $type;
     }
 
+    /** @param class-string<\BackedEnum> $enum */
+    public static function fromBackedEnum(string $enum): self
+    {
+        // @phpstan-ignore-next-line argument.type
+        return self::$cache[$enum] ??= new self(array_column($enum::cases(), column_key: 'value'));
+    }
+
     public function coerce(mixed $value, CoerceState $state): mixed
     {
         $this->tally($value, state: $state);
@@ -42,9 +52,10 @@ public function dump(mixed $value, DumpState $state): mixed
 
     private function tally(mixed $value, CoerceState|DumpState $state): void
     {
-        if (in_array($value, haystack: $this->members, strict: true)) {
+        $needle = $value instanceof \BackedEnum ? $value->value : $value;
+        if (in_array($needle, haystack: $this->members, strict: true)) {
             ++$state->yes;
-        } elseif ($this->type === gettype($value)) {
+        } elseif ($this->type === gettype($needle)) {
             ++$state->maybe;
         } else {
             ++$state->no;