Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

Commit 53d432a

Browse files
committed
Update Trino version to 405
- Remove unused variables - Apply changed public or protected interfaces - Use execute with already created connection Signed-off-by: leeyh0216 <[email protected]>
1 parent 2fc81bb commit 53d432a

File tree

2 files changed

+19
-12
lines changed

2 files changed

+19
-12
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<parent>
77
<groupId>io.trino</groupId>
88
<artifactId>trino-root</artifactId>
9-
<version>396</version>
9+
<version>405</version>
1010
</parent>
1111

1212
<artifactId>trino-db2</artifactId>

src/main/java/io/trino/plugin/db2/DB2Client.java

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,14 @@
1818
import io.trino.plugin.jdbc.ColumnMapping;
1919
import io.trino.plugin.jdbc.ConnectionFactory;
2020
import io.trino.plugin.jdbc.JdbcSplit;
21+
import io.trino.plugin.jdbc.JdbcTableHandle;
2122
import io.trino.plugin.jdbc.JdbcTypeHandle;
2223
import io.trino.plugin.jdbc.LongReadFunction;
2324
import io.trino.plugin.jdbc.ObjectReadFunction;
2425
import io.trino.plugin.jdbc.ObjectWriteFunction;
2526
import io.trino.plugin.jdbc.QueryBuilder;
2627
import io.trino.plugin.jdbc.WriteMapping;
28+
import io.trino.plugin.jdbc.logging.RemoteQueryModifier;
2729
import io.trino.plugin.jdbc.mapping.IdentifierMapping;
2830
import io.trino.spi.TrinoException;
2931
import io.trino.spi.connector.ConnectorSession;
@@ -34,7 +36,6 @@
3436
import io.trino.spi.type.LongTimestamp;
3537
import io.trino.spi.type.TimestampType;
3638
import io.trino.spi.type.Type;
37-
import io.trino.spi.type.TypeManager;
3839
import io.trino.spi.type.VarcharType;
3940

4041
import javax.inject.Inject;
@@ -116,22 +117,22 @@ public DB2Client(
116117
DB2Config db2config,
117118
ConnectionFactory connectionFactory,
118119
QueryBuilder queryBuilder,
119-
TypeManager typeManager,
120-
IdentifierMapping identifierMapping)
120+
IdentifierMapping identifierMapping,
121+
RemoteQueryModifier remoteQueryModifier)
121122
throws SQLException
122123
{
123-
super(config, "\"", connectionFactory, queryBuilder, identifierMapping);
124+
super(config, "\"", connectionFactory, queryBuilder, identifierMapping, remoteQueryModifier);
124125
this.varcharMaxLength = db2config.getVarcharMaxLength();
125126

126127
// http://stackoverflow.com/questions/16910791/getting-error-code-4220-with-null-sql-state
127128
System.setProperty("db2.jcc.charsetDecoderEncoder", "3");
128129
}
129130

130131
@Override
131-
public Connection getConnection(ConnectorSession session, JdbcSplit split)
132+
public Connection getConnection(ConnectorSession session, JdbcSplit split, JdbcTableHandle jdbcTableHandle)
132133
throws SQLException
133134
{
134-
Connection connection = super.getConnection(session, split);
135+
Connection connection = super.getConnection(session, split, jdbcTableHandle);
135136
try {
136137
// TRANSACTION_READ_UNCOMMITTED = Uncommitted read
137138
// http://www.ibm.com/developerworks/data/library/techarticle/dm-0509schuetz/
@@ -309,10 +310,10 @@ else if (varcharType.getBoundedLength() < this.varcharMaxLength) {
309310
return WriteMapping.longMapping(format("TIMESTAMP(%s)", timestampType.getPrecision()), timestampWriteFunction(timestampType));
310311
}
311312

312-
return this.legacyToWriteMapping(session, type);
313+
return this.legacyToWriteMapping(type);
313314
}
314315

315-
protected WriteMapping legacyToWriteMapping(ConnectorSession session, Type type)
316+
protected WriteMapping legacyToWriteMapping(Type type)
316317
{
317318
if (type instanceof VarcharType) {
318319
VarcharType varcharType = (VarcharType) type;
@@ -380,15 +381,15 @@ protected void renameTable(ConnectorSession session, String catalogName, String
380381
"RENAME TABLE %s TO %s",
381382
quoted(catalogName, schemaName, tableName),
382383
quoted(newTableName));
383-
execute(connection, sql);
384+
execute(session, connection, sql);
384385
}
385386
catch (SQLException e) {
386387
throw new TrinoException(JDBC_ERROR, e);
387388
}
388389
}
389390

390391
@Override
391-
protected void copyTableSchema(Connection connection, String catalogName, String schemaName, String tableName, String newTableName, List<String> columnNames)
392+
protected void copyTableSchema(ConnectorSession session, Connection connection, String catalogName, String schemaName, String tableName, String newTableName, List<String> columnNames)
392393
{
393394
String sql = format(
394395
"CREATE TABLE %s AS (SELECT %s FROM %s) WITH NO DATA",
@@ -397,6 +398,12 @@ protected void copyTableSchema(Connection connection, String catalogName, String
397398
.map(this::quoted)
398399
.collect(joining(", ")),
399400
quoted(catalogName, schemaName, tableName));
400-
execute(connection, sql);
401+
402+
try {
403+
execute(session, connection, sql);
404+
}
405+
catch (SQLException e) {
406+
throw new TrinoException(JDBC_ERROR, e);
407+
}
401408
}
402409
}

0 commit comments

Comments
 (0)