Skip to content

Commit b783823

Browse files
authored
feat(database): add show duration param to update (#89)
1 parent 3f3b207 commit b783823

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

changelog.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# CHANGELOG
22

3+
## 3.1.2
4+
CHANGED:
5+
- reduce log verbosity on database update
6+
37
## 3.1.1
48
CHANGED:
59
- database connection managment now handled by separate class, that implements retries and timeout

r2gg/_database.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,17 +137,19 @@ def execute_select_fetch_multiple(self, query, batchsize=1, show_duration=False)
137137

138138
# the method below should be used as a generator function otherwise use execute_update
139139
@database_retry_decorator
140-
def execute_update_query(self, query, params=None, isolation_level=None):
141-
self.logger.info("SQL: {}".format(query))
140+
def execute_update_query(self, query, params=None, isolation_level=None, show_duration=False):
141+
if show_duration :
142+
self.logger.info("SQL: {}".format(query))
142143
st_execute = time.time()
143144
with self._connection.cursor(cursor_factory=DictCursor) as cursor:
144145
old_isolation_level = self._connection.isolation_level
145146
if isolation_level is not None:
146147
self._connection.set_isolation_level(isolation_level)
147148
cursor.execute(query, params)
148149
self._connection.commit()
149-
et_execute = time.time()
150-
self.logger.info("Execution ended. Elapsed time : %s seconds." % (et_execute - st_execute))
150+
if show_duration:
151+
et_execute = time.time()
152+
self.logger.info("Execution ended. Elapsed time : %s seconds." % (et_execute - st_execute))
151153
self._connection.set_isolation_level(old_isolation_level)
152154
yield # the decorator database_retry_decorator only supports generators
153155
return

0 commit comments

Comments
 (0)