Unable to change the 'termsOfAccess' field on an unrestricted dataset/file created through API when 'termsOfAccess' accidentally set

[bseeger]

What steps does it take to reproduce the issue?

Create a dataset through the API with material in the 'termsOfAccess' field, but do not make the dataset restricted.
In our case, the dataset's files are not restricted, but we put material in the 'termsOfAccess' field. This results in the file preview terms popup appearing, even for CC0 records. That's expected, but we didn't want that and if you look at the record in the UI, you cannot edit the 'termsOfAccess', though you can see that it's set. An admin is then unable to easily remove the material in that field, if we no longer want it. We are stuck being unable to edit those fields.

• When does this issue occur?
  This occurs when material is uploaded via the API, and a value is placed in the 'termsOfAccess' field, even though the file is unrestricted.

We populated that field with out realizing that it would cause a popup on the file viewer page, even for CC0 records. When we went to the UI to change it, we realized we couldn't.

• Which page(s) does it occurs on?
  This occurs on the "Terms" tab of a dataset

• What happens?

• To whom does it occur (all users, curators, superusers)?

• What did you expect to happen?
  I expected to be able to edit the 'termsOfAccess' field to fix the issue we are seeing - which is a popup on the file previewer for even CC0 records.

Note: Jim Meyers helped with a work around -- if you go to restrict a file, then you can edit the "Request Access" and "termsOfAccess" field. Essentially, restrict the file and then unrestrict it. That does fix the issue.

Which version of Dataverse are you using?
Version 6.6

Any related open or closed issues to this bug report?
Not that I know of.

Here is a related conversation that happened in chat.
https://dataverse.zulipchat.com/#narrow/channel/378866-troubleshooting/topic/Terms.20of.20Use.20popup.20on.20file.20previewer/with/566971277

Screenshots:

Here is what the page for a dataset looks like when this happens (the files are not restricted):

Are you thinking about creating a pull request for this issue?
Help is always welcome, is this bug something you or your organization plan to fix?

[jggautier]

@bseeger, @pdurbin and I chatted a little in a Zulip thread about "adjusting the API endpoint that @bseeger used to remove or reduce the chance that datasets can get in this state, where there's something in the "Terms of Access for Restricted File" field but there's no restricted files."

If the dataset doesn't have restricted files, but there's anything in the "Terms of Access for Restricted File" field, maybe the API endpoint could return an error message that the dataset has no restricted files, so the "Terms of Access for Restricted File" field must be blank.