Don't panic in Exists#ExtractConditions() & drop superfluous type assertion

yhabteab · yhabteab · commit bc6536e2072f · 2023-11-16T14:48:38.000+01:00
diff --git a/internal/filter/types.go b/internal/filter/types.go
@@ -74,10 +74,6 @@ func (c *Chain) Eval(filterable Filterable) (bool, error) {
 func (c *Chain) ExtractConditions() []*Condition {
 	var conditions []*Condition
 	for _, rule := range c.rules {
-		if _, ok := rule.(*Exists); ok {
-			continue
-		}
-
 		conditions = append(conditions, rule.ExtractConditions()...)
 	}
 
@@ -197,7 +193,7 @@ type Exists struct {
 }
 
 func (e *Exists) ExtractConditions() []*Condition {
-	panic("filter exists doesn't support extract conditions")
+	return nil
 }
 
 func NewExists(column string) *Exists {

Original file line number	Diff line number	Diff line change
`@@ -74,10 +74,6 @@ func (c *Chain) Eval(filterable Filterable) (bool, error) {`
`74`	`74`	`func (c Chain) ExtractConditions() []Condition {`
`75`	`75`	`var conditions []*Condition`
`76`	`76`	`for _, rule := range c.rules {`
`77`		`- if _, ok := rule.(*Exists); ok {`
`78`		`- continue`
`79`		`- }`
`80`		`-`
`81`	`77`	`conditions = append(conditions, rule.ExtractConditions()...)`
`82`	`78`	`}`
`83`	`79`
`@@ -197,7 +193,7 @@ type Exists struct {`
`197`	`193`	`}`
`198`	`194`
`199`	`195`	`func (e Exists) ExtractConditions() []Condition {`
`200`		`- panic("filter exists doesn't support extract conditions")`
	`196`	`+ return nil`
`201`	`197`	`}`
`202`	`198`
`203`	`199`	`func NewExists(column string) *Exists {`