-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
Description
When updating a channel name within the web UI, the logs are still using the old name. This happens because the logger is created within the createFn
but not altered/recreated in the updateFn
.
icinga-notifications/internal/config/channel.go
Lines 15 to 17 in 860ea0c
newElement.Start(context.TODO(), r.logs.GetChildLogger("channel").With( | |
zap.Int64("id", newElement.ID), | |
zap.String("name", newElement.Name))) |
icinga-notifications/internal/config/channel.go
Lines 20 to 27 in 860ea0c
func(curElement, update *channel.Channel) error { | |
curElement.ChangedAt = update.ChangedAt | |
curElement.Name = update.Name | |
curElement.Type = update.Type | |
curElement.Config = update.Config | |
curElement.Restart() | |
return nil | |
}, |
This pattern should be checked for each runtime update, not only for channels.
Reported by @sukhwinder33445, thanks!
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working