Merge pull request #10215 from Icinga/Al2Klimov-patch-3

Atomic<T>#Atomic(T): fix C++ compliance

Author: Al2Klimov

lib/base/atomic.hpp

@@ -12,32 +12,25 @@ namespace icinga
 {
 
 /**
- * Extends std::atomic with an atomic constructor.
+ * Like std::atomic, but enforces usage of its only safe constructor.
+ *
+ * "The default-initialized std::atomic<T> does not contain a T object,
+ * and its only valid uses are destruction and
+ * initialization by std::atomic_init, see LWG issue 2334."
+ *  -- https://en.cppreference.com/w/cpp/atomic/atomic/atomic
  *
  * @ingroup base
  */
 template<class T>
 class Atomic : public std::atomic<T> {
 public:
 	/**
-	 * Like std::atomic#atomic, but operates atomically
-	 *
-	 * @param desired Initial value
-	 */
-	inline Atomic(T desired)
-	{
-		this->store(desired);
-	}
-
-	/**
-	 * Like std::atomic#atomic, but operates atomically
+	 * The only safe constructor of std::atomic#atomic
 	 *
 	 * @param desired Initial value
-	 * @param order Initial store operation's memory order
 	 */
-	inline Atomic(T desired, std::memory_order order)
+	inline Atomic(T desired) : std::atomic<T>(desired)
 	{
-		this->store(desired, order);
 	}
 };