Merge pull request #10389 from Icinga/zone-endpoint-order

Zone#GetEndpoints(): return endpoints in the specified order, not randomly🎲

Author: Al2Klimov

lib/icinga/apiactions.cpp

@@ -931,7 +931,7 @@ Dictionary::Ptr ApiActions::ExecuteCommand(const ConfigObject::Ptr& object, cons
 		for (const Zone::Ptr& zone : ConfigType::GetObjectsByType<Zone>()) {
 			/* Fetch immediate child zone members */
 			if (zone->GetParent() == localZone && zone->CanAccessObject(endpointPtr->GetZone())) {
-				std::set<Endpoint::Ptr> endpoints = zone->GetEndpoints();
+				auto endpoints (zone->GetEndpoints());
 
 				for (const Endpoint::Ptr& childEndpoint : endpoints) {
 					if (!(childEndpoint->GetCapabilities() & (uint_fast64_t)ApiCapabilities::ExecuteArbitraryCommand)) {

lib/icinga/clusterevents.cpp

@@ -966,7 +966,7 @@ Value ClusterEvents::ExecuteCommandAPIHandler(const MessageOrigin::Ptr& origin,
 			for (const Zone::Ptr &zone : ConfigType::GetObjectsByType<Zone>()) {
 				/* Fetch immediate child zone members */
 				if (zone->GetParent() == localZone && zone->CanAccessObject(endpointZone)) {
-					std::set<Endpoint::Ptr> endpoints = zone->GetEndpoints();
+					auto endpoints (zone->GetEndpoints());
 
 					for (const Endpoint::Ptr &childEndpoint : endpoints) {
 						if (!(childEndpoint->GetCapabilities() & (uint_fast64_t)ApiCapabilities::ExecuteArbitraryCommand)) {

lib/livestatus/zonestable.cpp

@@ -70,8 +70,7 @@ Value ZonesTable::EndpointsAccessor(const Value& row)
 	if (!zone)
 		return Empty;
 
-	std::set<Endpoint::Ptr> endpoints = zone->GetEndpoints();
-
+	auto endpoints (zone->GetEndpoints());
 	ArrayData result;
 
 	for (const Endpoint::Ptr& endpoint : endpoints) {

lib/remote/zone.cpp

@@ -51,10 +51,9 @@ Zone::Ptr Zone::GetParent() const
 	return m_Parent;
 }
 
-std::set<Endpoint::Ptr> Zone::GetEndpoints() const
+std::vector<Endpoint::Ptr> Zone::GetEndpoints() const
 {
-	std::set<Endpoint::Ptr> result;
-
+	std::vector<Endpoint::Ptr> result;
 	Array::Ptr endpoints = GetEndpointsRaw();
 
 	if (endpoints) {
@@ -66,7 +65,7 @@ std::set<Endpoint::Ptr> Zone::GetEndpoints() const
 			if (!endpoint)
 				continue;
 
-			result.insert(endpoint);
+			result.emplace_back(std::move(endpoint));
 		}
 	}
 

lib/remote/zone.hpp

@@ -22,7 +22,7 @@ class Zone final : public ObjectImpl<Zone>
 	void OnAllConfigLoaded() override;
 
 	Zone::Ptr GetParent() const;
-	std::set<Endpoint::Ptr> GetEndpoints() const;
+	std::vector<Endpoint::Ptr> GetEndpoints() const;
 	std::vector<Zone::Ptr> GetAllParentsRaw() const;
 	Array::Ptr GetAllParents() const override;