Skip to content

Commit ae06649

Browse files
committed
Drop System#track_parents DSL function
No external user needs to manipulate the actual object dependency graphs. This was maybe introduced for debugging purposes at that time but if someone messes with this in prod - good luck with that. Oh, apart from that it's broken :( and doesn't track parents as its implies but children.
1 parent 5b1b2fb commit ae06649

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

lib/base/scriptutils.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
#include "base/objectlock.hpp"
1212
#include "base/configtype.hpp"
1313
#include "base/application.hpp"
14-
#include "base/dependencygraph.hpp"
1514
#include "base/initialize.hpp"
1615
#include "base/namespace.hpp"
1716
#include "config/configitem.hpp"
@@ -49,7 +48,6 @@ REGISTER_SAFE_FUNCTION(System, basename, &Utility::BaseName, "path");
4948
REGISTER_SAFE_FUNCTION(System, dirname, &Utility::DirName, "path");
5049
REGISTER_SAFE_FUNCTION(System, getenv, &ScriptUtils::GetEnv, "value");
5150
REGISTER_SAFE_FUNCTION(System, msi_get_component_path, &ScriptUtils::MsiGetComponentPathShim, "component");
52-
REGISTER_SAFE_FUNCTION(System, track_parents, &ScriptUtils::TrackParents, "child");
5351
REGISTER_SAFE_FUNCTION(System, escape_shell_cmd, &Utility::EscapeShellCmd, "cmd");
5452
REGISTER_SAFE_FUNCTION(System, escape_shell_arg, &Utility::EscapeShellArg, "arg");
5553
#ifdef _WIN32
@@ -518,11 +516,6 @@ String ScriptUtils::MsiGetComponentPathShim(const String& component)
518516
#endif /* _WIN32 */
519517
}
520518

521-
Array::Ptr ScriptUtils::TrackParents(const Object::Ptr& child)
522-
{
523-
return Array::FromVector(DependencyGraph::GetChildren(dynamic_pointer_cast<ConfigObject>(child)));
524-
}
525-
526519
double ScriptUtils::Ptr(const Object::Ptr& object)
527520
{
528521
return reinterpret_cast<intptr_t>(object.get());

lib/base/scriptutils.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ class ScriptUtils
3939
static Array::Ptr GetObjects(const Type::Ptr& type);
4040
static void Assert(const Value& arg);
4141
static String MsiGetComponentPathShim(const String& component);
42-
static Array::Ptr TrackParents(const Object::Ptr& parent);
4342
static double Ptr(const Object::Ptr& object);
4443
static Value Glob(const std::vector<Value>& args);
4544
static Value GlobRecursive(const std::vector<Value>& args);

0 commit comments

Comments
 (0)