Fix the last linter errors. Turn on fail on linter errors.

Author: mikaelfrykholm

.github/workflows/python-package.yml

@@ -28,7 +28,7 @@ jobs:
       run: |
         pip install ruff
         ruff check --output-format=github .
-      continue-on-error: true
+      continue-on-error: false
 
     - name: Install dependencies
       run: |

src/pyff/test/test_repo.py

@@ -141,7 +141,7 @@ def test_display(self):
         funet_connect = self.md.lookup('https://connect.funet.fi/shibboleth')[0]
         name, desc = entity_extended_display(funet_connect)
         assert name == 'FUNET E-Meeting Service'
-        dn = entity_extended_display(funet_connect)
+        _dn = entity_extended_display(funet_connect)
 
     def test_missing(self):
         swamid = root(self.swamid)

src/pyff/test/test_rwlock.py

@@ -122,7 +122,7 @@ def test_unthreaded(self):
         finally:
             try:
                 self.lock.release()
-            except:
+            except Exception:
                 pass
 
     def test_deadlock(self):

src/pyff/test/test_store.py

@@ -125,7 +125,7 @@ def test_select_wayf(self):
     def test_lookup_intersect_empty_test01(self):
         store = RedisWhooshStore(directory=self.dir, clear=True, name="test", redis=fakeredis.FakeStrictRedis())
         store.update(self.test01, etag='test01', lazy=False)
-        entity_id = root(self.test01).get('entityID')
+        _entity_id = root(self.test01).get('entityID')
         e = store.lookup("{}={}+{}={}".format(ATTRS['domain'], 'example.com', ATTRS['role'], 'sp'))
         assert len(e) == 0
 
@@ -258,7 +258,7 @@ def test_lookup_intersect_test01(self):
     def test_lookup_intersect_empty_test01(self):
         store = MemoryStore()
         store.update(self.test01)
-        entity_id = root(self.test01).get('entityID')
+        _entity_id = root(self.test01).get('entityID')
         e = store.lookup("{}={}+{}={}".format(ATTRS['domain'], 'example.com', ATTRS['role'], 'sp'))
         assert len(e) == 0