feat: Let InputBinaryStream inherit from InputStreamBase

Very much reduces the amount of duplicate code.

Adds the ability to call `GetPointer()` on an InputBinaryStream, just like it
was already supported on an InputTextStream.

Author: N-Dekker

include/itkInputBinaryStream.h

@@ -20,14 +20,11 @@
 
 #include "itkPipeline.h"
 #include "itkWasmStringStream.h"
+#include "itkInputStreamBase.h"
 
 #include <string>
-#ifndef ITK_WASM_NO_MEMORY_IO
-#  include <sstream>
-#endif
-#ifndef ITK_WASM_NO_FILESYSTEM_IO
-#  include <fstream>
-#endif
+#include <sstream>
+#include <fstream>
 
 #include "WebAssemblyInterfaceExport.h"
 
@@ -40,66 +37,18 @@ namespace wasm
  *\class InputBinaryStream
  * \brief Input binary std::istream for an itk::wasm::Pipeline
  *
- * This stream is read from the filesystem or memory when ITK_WASM_PARSE_ARGS is called.
- *
- * Call `Get()` to get the std::istream & to use an input to a pipeline.
- *
  * \ingroup WebAssemblyInterface
  */
-class WebAssemblyInterface_EXPORT InputBinaryStream
+class WebAssemblyInterface_EXPORT InputBinaryStream : public InputStreamBase
 {
 public:
-  std::istream &
-  Get()
-  {
-    return *m_IStream;
-  }
-
   void
-  SetJSON(const std::string & json)
+  SetFileName(const std::string & fileName) override
   {
-    if (m_DeleteIStream && m_IStream != nullptr)
-    {
-      delete m_IStream;
-    }
-    m_DeleteIStream = false;
-    m_WasmStringStream = WasmStringStream::New();
-    m_WasmStringStream->SetJSON(json.c_str());
-
-    m_IStream = &(m_WasmStringStream->GetStringStream());
+    InputStreamBase::SetFile(fileName, std::ios_base::binary);
   }
-
-  void
-  SetFileName(const std::string & fileName)
-  {
-    if (m_DeleteIStream && m_IStream != nullptr)
-    {
-      delete m_IStream;
-    }
-    m_IStream = new std::ifstream(fileName, std::ifstream::in | std::ifstream::binary);
-    m_DeleteIStream = true;
-  }
-
-  InputBinaryStream() = default;
-  ~InputBinaryStream()
-  {
-    if (m_DeleteIStream && m_IStream != nullptr)
-    {
-      delete m_IStream;
-    }
-  }
-
-private:
-  std::istream * m_IStream{ nullptr };
-  bool           m_DeleteIStream{ false };
-
-  WasmStringStream::Pointer m_WasmStringStream;
 };
 
-
-WebAssemblyInterface_EXPORT bool
-lexical_cast(const std::string & input, InputBinaryStream & inputStream);
-
 } // end namespace wasm
 } // end namespace itk
 

src/CMakeLists.txt

@@ -16,7 +16,6 @@ set(WebAssemblyInterface_SRCS
   itkWasmStringStream.cxx
   itkInputStreamBase.cxx
   itkOutputTextStream.cxx
-  itkInputBinaryStream.cxx
   itkOutputBinaryStream.cxx
   itkIOComponentEnumFromWasmComponentType.cxx
   itkIOPixelEnumFromWasmPixelType.cxx