STYLE: Use Image::CreateInitialized(const RegionType &) in tests

Replaced more than sixty cases of code like:

    auto image = ImageType::New();
    image->SetRegions(region);
    image->AllocateInitialized();

with the following single statement:

    auto image = ImageType::CreateInitialized(region);

in ITK test files ("itk*Test*.cxx").

Author: N-Dekker

Modules/Core/Common/test/itkAdaptorComparisonTest.cxx

@@ -195,11 +195,9 @@ itkAdaptorComparisonTest(int, char *[])
   region.SetSize(size);
   region.SetIndex(index);
 
-  auto scalar_image = ScalarImageType::New();
-  auto vector_image = VectorImageType::New();
+  auto scalar_image = ScalarImageType::CreateInitialized(region);
 
-  scalar_image->SetRegions(region);
-  scalar_image->AllocateInitialized();
+  auto vector_image = VectorImageType::New();
 
   vector_image->SetRegions(region);
   vector_image->Allocate();

Modules/Core/Common/test/itkBSplineInterpolationWeightFunctionTest.cxx

@@ -275,13 +275,11 @@ itkBSplineInterpolationWeightFunctionTest(int, char *[])
     auto kernel = KernelType::New();
 
     using ImageType = itk::Image<char, SpaceDimension>;
-    auto                  image = ImageType::New();
     ImageType::RegionType region;
     region.SetIndex(startIndex);
     region.SetSize(size);
 
-    image->SetRegions(region);
-    image->AllocateInitialized();
+    auto image = ImageType::CreateInitialized(region);
 
     using IteratorType = itk::ImageRegionConstIteratorWithIndex<ImageType>;
     IteratorType  iter(image, image->GetBufferedRegion());

Modules/Core/Common/test/itkConnectedImageNeighborhoodShapeGTest.cxx

@@ -248,11 +248,9 @@ TEST(ConnectedImageNeighborhoodShape, SupportsConstShapedNeighborhoodIterator)
   using OffsetType = itk::Offset<ImageDimension>;
 
   // Create a "dummy" image.
-  const auto image = ImageType::New();
-  SizeType   imageSize;
+  SizeType imageSize;
   imageSize.Fill(1);
-  image->SetRegions(imageSize);
-  image->AllocateInitialized();
+  const auto image = ImageType::CreateInitialized(imageSize);
 
   // Create a radius, (just) large enough for all offsets activated below here.
   SizeType radius;

Modules/Core/Common/test/itkImageAlgorithmCopyTest2.cxx

@@ -79,14 +79,8 @@ itkImageAlgorithmCopyTest2(int, char *[])
   image1->Allocate();
   image1->FillBuffer(13);
 
-  auto image2 = Short3DImageType::New();
-  image2->SetRegions(region);
-  image2->AllocateInitialized();
-
-
-  auto image3 = Float3DImageType::New();
-  image3->SetRegions(region);
-  image3->AllocateInitialized();
+  auto image2 = Short3DImageType::CreateInitialized(region);
+  auto image3 = Float3DImageType::CreateInitialized(region);
 
   std::cout << "Copying two images of same type" << std::endl;
   itk::ImageAlgorithm::Copy(image1.GetPointer(), image2.GetPointer(), region, region);

Modules/Core/Common/test/itkImageDuplicatorTest.cxx

@@ -41,9 +41,7 @@ itkImageDuplicatorTest(int, char *[])
   {
     /** Create an image image */
     std::cout << "Creating simulated image: ";
-    auto m_Image = ImageType::New();
-    m_Image->SetRegions(region);
-    m_Image->AllocateInitialized();
+    auto m_Image = ImageType::CreateInitialized(region);
 
     itk::ImageRegionIterator<ImageType> it(m_Image, region);
     it.GoToBegin();

Modules/Core/Common/test/itkImageGTest.cxx

@@ -83,11 +83,7 @@ void
 Expect_allocated_initialized_image_equal_to_itself()
 {
   using SizeType = typename TImage::SizeType;
-
-  const auto image = TImage::New();
-  image->SetRegions(SizeType::Filled(2));
-  image->AllocateInitialized();
-
+  const auto image = TImage::CreateInitialized(SizeType::Filled(2));
   Expect_equal_to_itself(*image);
 }
 
@@ -98,13 +94,8 @@ Expect_unequal_when_sizes_differ()
 {
   using SizeType = typename TImage::SizeType;
 
-  const auto image1 = TImage::New();
-  image1->SetRegions(SizeType::Filled(2));
-  image1->AllocateInitialized();
-
-  const auto image2 = TImage::New();
-  image2->SetRegions(SizeType::Filled(3));
-  image2->AllocateInitialized();
+  const auto image1 = TImage::CreateInitialized(SizeType::Filled(2));
+  const auto image2 = TImage::CreateInitialized(SizeType::Filled(3));
 
   Expect_unequal(*image1, *image2);
 }

Modules/Core/Common/test/itkImageRandomIteratorTest2.cxx

@@ -43,8 +43,6 @@ itkImageRandomIteratorTest2(int argc, char * argv[])
 
   using ImageType = itk::Image<PixelType, ImageDimension>;
 
-  auto image = ImageType::New();
-
   ImageType::SizeType size;
 
   size[0] = 1000;
@@ -59,8 +57,7 @@ itkImageRandomIteratorTest2(int argc, char * argv[])
   region.SetIndex(start);
   region.SetSize(size);
 
-  image->SetRegions(region);
-  image->AllocateInitialized();
+  auto image = ImageType::CreateInitialized(region);
 
   using RandomIteratorType = itk::ImageRandomIteratorWithIndex<ImageType>;
 

Modules/Core/Common/test/itkImageRegionRangeGTest.cxx

@@ -628,13 +628,10 @@ TEST(ImageRegionRange, ThrowsInReleaseWhenIterationRegionIsOutsideBufferedRegion
   using SizeType = ImageType::SizeType;
   using RegionType = ImageType::RegionType;
 
-  const auto image = ImageType::New();
-
   const IndexType imageIndex{ { -1, -2 } };
   const SizeType  imageSize{ { 3, 4 } };
 
-  image->SetRegions(RegionType{ imageIndex, imageSize });
-  image->AllocateInitialized();
+  const auto image = ImageType::CreateInitialized({ imageIndex, imageSize });
 
   Check_Range_constructor_throws_ExceptionObject_when_iteration_region_is_outside_of_buffered_region(
     *image, RegionType{ imageIndex, imageSize + SizeType::Filled(1) });

Modules/Core/Common/test/itkLineIteratorTest.cxx

@@ -52,9 +52,7 @@ itkLineIteratorTest(int argc, char * argv[])
   region.SetIndex(index);
   region.SetSize(size);
 
-  auto output = ImageType::New();
-  output->SetRegions(region);
-  output->AllocateInitialized();
+  auto output = ImageType::CreateInitialized(region);
 
   // First test: empty line
   IndexType startIndex;

Modules/Core/Common/test/itkShapedImageNeighborhoodRangeGTest.cxx

@@ -1004,9 +1004,7 @@ TEST(ShapedImageNeighborhoodRange, SupportsArbitraryBufferedRegionIndex)
 
   const ImageType::RegionType bufferedRegion{ arbitraryIndex, imageSize };
 
-  const auto image = ImageType::New();
-  image->SetRegions(bufferedRegion);
-  image->AllocateInitialized();
+  const auto image = ImageType::CreateInitialized(bufferedRegion);
 
   // Set a 'magic value' at the begin of the buffered region.
   const ImageType::PixelType   magicPixelValue = 42;