Release 10.6 final integration #6331
Conversation
Node 10.6.0 config and nix updates
carbolymer
force-pushed
the
ana/10.6-final-integration-mix
branch
from
90edc7b to
0ecd14d
Compare
carbolymer
force-pushed
the
ana/10.6-final-integration-mix
branch
from
0ecd14d to
706faab
Compare
| -- Enable peer to peer discovery | ||
| , ("EnableP2P", Aeson.Bool False) | ||
| -- Enable P2P, non-P2P is gone | ||
| , ("EnableP2P", Aeson.Bool True) |
There was a problem hiding this comment.
If non-P2P is gone why bother keeping the "EnableP2P" configuration key?
| (pledgerSAddr, _rewards, _poolId) <- H.headM $ mergeDelegsAndRewards delegsAndRewards | ||
|
|
||
| -- Pledger and owner are and can be the same | ||
| Text.unpack (serialiseAddress pledgerSAddr) === poolownerstakeaddr |
There was a problem hiding this comment.
Why has this check been removed?
There was a problem hiding this comment.
Because it does not make sense. You have multiple stake addresses in the list in the arbitrary order and it fails randomly. The check that poolownerstakeaddr is in the list is already done in checkStakeKeyRegistered.
| H.renameFile (tempAbsPath' </> "shelley/genesis.json") (tempAbsPath' </> defaultGenesisFilepath ShelleyEra) | ||
| H.renameFile (tempAbsPath' </> "shelley/genesis.alonzo.json") (tempAbsPath' </> defaultGenesisFilepath AlonzoEra) | ||
| H.renameFile (tempAbsPath' </> "shelley/genesis.conway.json") (tempAbsPath' </> defaultGenesisFilepath ConwayEra) | ||
| -- TODO: once 'cardano-cli latest genesis create' supports dijkstra, make this a copy instead of writing a default |
There was a problem hiding this comment.
@carbolymer can you turn this into an issue so we can track it.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thank you for this contribution. I’ve reviewed the changes related to the tracing system and have some important observations:
Incomplete removal of tracing constructors
According to the network changelog, the following were removed:
TraceLedgerPeersResult
TraceLedgerPeersFailure
However, this removal appears to be incomplete. Some references are still present in the codebase, leading to inconsistency and potential confusion during tracing. I will prepare a follow-up commit tomorrow to fully remove the remaining instances and ensure consistency.
TraceChurnMode still present
The changelog also states that:
TraceChurnMode was removed from TracePeerSelection
However, TraceChurnMode still appears in the node codebase—possibly used in a different context now. Before proceeding, I believe the network team should verify that is still required and if the codebase is fully adopted to this change. Otherwise, it may result in dead code or misleading trace output.
Additional tracing inconsistencies
While reviewing this PR, I found several smaller issues and inconsistencies in the trace definitions that should be addressed for correctness and maintainability. I will include these fixes in a follow-up commit tomorrow.
| Api.AlonzoEraOnwardsBabbage -> renderAlonzoPlutusPurpose | ||
| Api.AlonzoEraOnwardsConway -> renderConwayPlutusPurpose | ||
| -- TODO: fix | ||
| Api.AlonzoEraOnwardsDijkstra -> undefined |
There was a problem hiding this comment.
Still an undefined in the code
jutaro
force-pushed
the
ana/10.6-final-integration-mix
branch
from
ab91132 to
0eaa1e7
Compare
carbolymer
force-pushed
the
ana/10.6-final-integration-mix
branch
from
f94636d to
9a132bb
Compare
mgmeier
force-pushed
the
ana/10.6-final-integration-mix
branch
from
e274262 to
9a132bb
Compare
Needs #6327 #6290
Description
Add your description here, if it fixes a particular issue please provide a
link
to the issue.
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.