Prototype experiment: only hold back underfull runs when this can't create an overfull run #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheinzel
force-pushed
the
mheinzel/prototype-tweaks
branch
2 times, most recently
from
962767a to
199466d
Compare
This way we always know the exact assertion that failed.
The adjustment of the calculation is necessary to avoid assertion failures for the new assertion.
This is necessary to accomodate 5-way merges due to holding back runs that are too small.
mheinzel
force-pushed
the
mheinzel/prototype-tweaks
branch
from
199466d to
68e44f7
Compare
The invariants here are actually not quite true. In pathological cases, runs can get even more than one size too small.
mheinzel
force-pushed
the
mheinzel/prototype-tweak-holding-back
branch
from
075b520 to
fbda802
Compare
mheinzel
force-pushed
the
mheinzel/prototype-tweaks
branch
from
68e44f7 to
44a8cd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.