Skip to content

Commit 14fde53

Browse files
committed
Fix Trag-bot review issues
- Removed trivial comments - Fixed CHANGELOG.md
1 parent 033201c commit 14fde53

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
9292
- We improved the event viewer for debugging [#13783](https://github.com/JabRef/jabref/pull/13783).
9393
- We improved "REDACTED" replacement of API key value in web fetcher search URL [#13796](https://github.com/JabRef/jabref/issues/13796)
9494
- When the pin "Keep dialog always on top" in the global search dialog is selected, the search window stays open when double-clicking on an entry. [#13840](https://github.com/JabRef/jabref/issues/13840)
95-
- We separated the "Clean up entries" dialog into three tabs for clarity [13819](https://github.com/JabRef/jabref/issues/13819)
95+
- We separated the "Clean up entries" dialog into three tabs for clarity [#13819](https://github.com/JabRef/jabref/issues/13819)
9696

9797
### Fixed
9898

jabgui/src/main/java/org/jabref/gui/cleanup/CleanupDialog.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,11 @@ public CleanupDialog(BibDatabaseContext databaseContext, CleanupPreferences init
3838
if (button.getButtonData() == ButtonBar.ButtonData.OK_DONE) {
3939
Tab selectedTab = tabPane.getSelectionModel().getSelectedItem();
4040
CleanupPanel panel = (CleanupPanel) selectedTab.getContent();
41+
/*
42+
* Returning null here is intentional: indicates either user cancelled
43+
* the dialog or panel had no preferences selected. Dialog.showAndWait()
44+
* will return Optional.empty() if null.
45+
*/
4146
return panel.getCleanupPreferences().orElse(null);
4247
} else {
4348
return null;

jabgui/src/main/java/org/jabref/gui/cleanup/CleanupFileRelatedPanel.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ private void init(BibDatabaseContext databaseContext, CleanupPreferences cleanup
4646
} else {
4747
cleanUpMovePdf.setText(Localization.lang("Move linked files to default file directory %0", "..."));
4848

49-
// Since the directory does not exist, we cannot move it to there. So, this option is not checked - regardless of the presets stored in the preferences.
5049
cleanUpMovePdf.setDisable(true);
5150
cleanUpMovePdf.setSelected(false);
5251
}

jablib/src/main/java/org/jabref/logic/cleanup/CleanupPreferences.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,6 @@ public void setFieldFormatterCleanups(FieldFormatterCleanups fieldFormatters) {
7373
fieldFormatterCleanups.setValue(fieldFormatters);
7474
}
7575

76-
/*
77-
* Categories are used to group CleanupSteps by tab type. This allows the updateWith()
78-
* method to replace only the steps of the same category when merging preferences from
79-
* a single tab, without affecting other categories.
80-
*/
8176
public CleanupPreferences updateWith(CleanupPreferences tabPreferences) {
8277
EnumSet<CleanupStep> mergedJobs = getActiveJobs();
8378

0 commit comments

Comments
 (0)