Skip to content

Misuse of getAll in Lusk #66

@sovdeeth

Description

@sovdeeth

Describe the bug
Many places in Lusk use getAll when they should be using getArray, which means or lists do not work as intended.

List of incidents

(impacts all boolean properties)
change(mode, getExpr().getAll(event), delta == null ? null : (T) delta[0]);
(impacts all simpler properties)
change(mode, getExpr().getAll(event), (T[]) delta);
(you get the point)



for (LivingEntity livingEntity : entityExpression.getAll(event)) {




Metadata

Metadata

Assignees

Labels

Area: Lusk (Skript)Takes place in the 'skript' module. More specifically in the skript implementation.Priority: HighNeeds to be addressed as soon as possible.Status: PlannedPlanned for implementation. Not waiting on other features or changes to be implemented.Type: BugSomething isn't working

Projects

Status

Accepted

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions