Skip to content

Commit eed878f

Browse files
Apply suggested fix to src/main/java/org/jlab/sim/presentation/controller/Directory.java from Copilot Autofix
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
1 parent 00548b3 commit eed878f

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

src/main/java/org/jlab/sim/presentation/controller/Directory.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@
3737
public class Directory extends HttpServlet {
3838

3939
@Serial private static final long serialVersionUID = 1L;
40+
private static final String LOOSE_PARAMETER = "loose";
41+
private static final String LOOSE_TRUE_VALUE = "Y";
4042

4143
@EJB SoftwareService softwareService;
4244
@EJB RepositoryService repositoryService;
@@ -120,14 +122,17 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response)
120122
request.setAttribute("gapList", Arrays.asList(DocumentationGaps.values()));
121123
request.setAttribute("esotericismList", Arrays.asList(Esotericism.values()));
122124

123-
final String YES = "Y";
124-
if (YES.equals(request.getParameter("loose"))) {
125+
if (isLooseModeRequested(request)) {
125126
request.getRequestDispatcher("/WEB-INF/views/directory-loose.jsp").forward(request, response);
126127
} else {
127128
request.getRequestDispatcher("/WEB-INF/views/directory.jsp").forward(request, response);
128129
}
129130
}
130131

132+
private boolean isLooseModeRequested(HttpServletRequest request) {
133+
return LOOSE_TRUE_VALUE.equals(request.getParameter(LOOSE_PARAMETER));
134+
}
135+
131136
private String createSelectionMessage(
132137
Paginator paginator,
133138
String softwareName,

0 commit comments

Comments
 (0)