use a different Kind for Fragment Arguments (#13)

at least for now!

Author: yaacovCR

src/index.ts

@@ -264,6 +264,7 @@ export type {
   SelectionNode,
   FieldNode,
   ArgumentNode,
+  FragmentArgumentNode,
   NullabilityAssertionNode,
   NonNullAssertionNode,
   ErrorBoundaryNode,

src/language/__tests__/visitor-test.ts

@@ -536,12 +536,12 @@ describe('Visitor', () => {
       ['enter', 'FragmentSpread', undefined],
       ['enter', 'Name', 's'],
       ['leave', 'Name', 's'],
-      ['enter', 'Argument', { kind: 'BooleanValue', value: false }],
+      ['enter', 'FragmentArgument', { kind: 'BooleanValue', value: false }],
       ['enter', 'Name', 'v'],
       ['leave', 'Name', 'v'],
       ['enter', 'BooleanValue', false],
       ['leave', 'BooleanValue', false],
-      ['leave', 'Argument', { kind: 'BooleanValue', value: false }],
+      ['leave', 'FragmentArgument', { kind: 'BooleanValue', value: false }],
       ['leave', 'FragmentSpread', undefined],
       ['leave', 'SelectionSet', undefined],
       ['leave', 'FragmentDefinition', undefined],

src/language/ast.ts

@@ -146,6 +146,7 @@ export type ASTNode =
   | SelectionSetNode
   | FieldNode
   | ArgumentNode
+  | FragmentArgumentNode
   | FragmentSpreadNode
   | InlineFragmentNode
   | FragmentDefinitionNode
@@ -221,6 +222,7 @@ export const QueryDocumentKeys: {
     'nullabilityAssertion',
   ],
   Argument: ['name', 'value'],
+  FragmentArgument: ['name', 'value'],
   // Note: Client Controlled Nullability is experimental and may be changed
   // or removed in the future.
   ListNullabilityOperator: ['nullabilityAssertion'],
@@ -422,13 +424,20 @@ export interface ConstArgumentNode {
   readonly value: ConstValueNode;
 }
 
+export interface FragmentArgumentNode {
+  readonly kind: Kind.FRAGMENT_ARGUMENT;
+  readonly loc?: Location | undefined;
+  readonly name: NameNode;
+  readonly value: ValueNode;
+}
+
 /** Fragments */
 
 export interface FragmentSpreadNode {
   readonly kind: Kind.FRAGMENT_SPREAD;
   readonly loc?: Location | undefined;
   readonly name: NameNode;
-  readonly arguments?: ReadonlyArray<ArgumentNode> | undefined;
+  readonly arguments?: ReadonlyArray<FragmentArgumentNode> | undefined;
   readonly directives?: ReadonlyArray<DirectiveNode> | undefined;
 }
 

src/language/index.ts

@@ -44,6 +44,7 @@ export type {
   ErrorBoundaryNode,
   ListNullabilityOperatorNode,
   ArgumentNode,
+  FragmentArgumentNode /* for experimental fragment arguments */,
   ConstArgumentNode,
   FragmentSpreadNode,
   InlineFragmentNode,

src/language/kinds.ts

@@ -12,6 +12,7 @@ export enum Kind {
   SELECTION_SET = 'SelectionSet',
   FIELD = 'Field',
   ARGUMENT = 'Argument',
+  FRAGMENT_ARGUMENT = 'FragmentArgument',
 
   /** Nullability Modifiers */
   LIST_NULLABILITY_OPERATOR = 'ListNullabilityOperator',

src/language/parser.ts

@@ -24,6 +24,7 @@ import type {
   FieldDefinitionNode,
   FieldNode,
   FloatValueNode,
+  FragmentArgumentNode,
   FragmentDefinitionNode,
   FragmentSpreadNode,
   InlineFragmentNode,
@@ -528,6 +529,12 @@ export class Parser {
     return this.optionalMany(TokenKind.PAREN_L, item, TokenKind.PAREN_R);
   }
 
+  /* experimental */
+  parseFragmentArguments(): Array<FragmentArgumentNode> {
+    const item = this.parseFragmentArgument;
+    return this.optionalMany(TokenKind.PAREN_L, item, TokenKind.PAREN_R);
+  }
+
   /**
    * Argument[Const] : Name : Value[?Const]
    */
@@ -549,6 +556,19 @@ export class Parser {
     return this.parseArgument(true);
   }
 
+  /* experimental */
+  parseFragmentArgument(): FragmentArgumentNode {
+    const start = this._lexer.token;
+    const name = this.parseName();
+
+    this.expectToken(TokenKind.COLON);
+    return this.node<FragmentArgumentNode>(start, {
+      kind: Kind.FRAGMENT_ARGUMENT,
+      name,
+      value: this.parseValueLiteral(false),
+    });
+  }
+
   // Implements the parsing rules in the Fragments section.
 
   /**
@@ -572,7 +592,7 @@ export class Parser {
         return this.node<FragmentSpreadNode>(start, {
           kind: Kind.FRAGMENT_SPREAD,
           name,
-          arguments: this.parseArguments(false),
+          arguments: this.parseFragmentArguments(),
           directives: this.parseDirectives(false),
         });
       }

src/language/printer.ts

@@ -76,6 +76,7 @@ const printDocASTReducer: ASTReducer<string> = {
     },
   },
   Argument: { leave: ({ name, value }) => name + ': ' + value },
+  FragmentArgument: { leave: ({ name, value }) => name + ': ' + value },
 
   // Nullability Modifiers