Repository navigation
build: Bump DD, avoid world age issue in Julia v1.12 - #130
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 53.68% 53.68%
=======================================
Files 10 10
Lines 1127 1127
=======================================
Hits 605 605
Misses 522 522 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
icweaver
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids this on Julia v1.12 for newer versions of AstroImages.jl rafaqz/DimensionalData.jl#937
The OrderedCollections.jl v1/v2 sitch led to a subtle downgrading of DD to older v0.29 versions (totally ignoring fully compatible newer v0.29 versions that include the world age fix) in the transitive deps. This just avoids all that.
We could also backport this to older AstroImages.jl releases, but idk if that's worth the churn