Skip to content

Commit 19396c7

Browse files
use julia_version Pkg.add kwarg rather than specifying it through ctx (#416)
* use julia_version kwarg rather than ctx * disable auto-precompilation on Pkg.add * add __version fix * fix tests * fix test_throws * Update dependencies.jl * narrow test to julia_version=nothing * handle different error types * unbroken fixed test * directly test setup_dependencies * dial in the tests * run on nightly * fix code mistake * update for new Zstd_jll path in v1.13 * set version in get_addable_spec * revert with comment * fix no version check * add a load of debugs * add 1.12-nightly to CI * update version check given backport * fixes
1 parent 99594c5 commit 19396c7

File tree

4 files changed

+168
-55
lines changed

4 files changed

+168
-55
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,13 @@ jobs:
6666
squashfs: true
6767
julia-version: "1.11"
6868

69-
# - runner: privileged
70-
# squashfs: true
71-
# julia-version: "nightly"
69+
- runner: privileged
70+
squashfs: true
71+
julia-version: "1.12-nightly"
72+
73+
- runner: privileged
74+
squashfs: true
75+
julia-version: "nightly"
7276

7377
# Add a job that uses the unprivileged builder with unpacked shards
7478
- runner: unprivileged

src/Dependencies.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -332,6 +332,9 @@ patch(v::VersionNumber) = v.patch
332332
major(v::Pkg.Types.VersionBound) = v.t[1]
333333
minor(v::Pkg.Types.VersionBound) = v.t[2]
334334
patch(v::Pkg.Types.VersionBound) = v.t[3]
335+
336+
# If a version in a PackageSpec is given as a string it signifies being a VersionSpec that Pkg will handle as such.
337+
__version(v::AbstractString) = __version(PKG_VERSIONS.VersionSpec(v))
335338
__version(v::VersionNumber) = v
336339
__version(v::PKG_VERSIONS.VersionSpec) = v.ranges[1].lower
337340
version(d::AbstractDependency) = __version(getpkg(d).version)

0 commit comments

Comments
 (0)