Conversation
Collaborator
Author
|
All tests pass with the new pin. Since this is a minor PR, I think it’s probably fine to merge, but I’ll defer to you here. If you’re okay with me merging small changes like this in the future, LMK |
gdalle
approved these changes
Jun 9, 2026
gdalle
left a comment
gdalle
left a comment
Member
There was a problem hiding this comment.
Yeah feel free to merge minor changes like that in the future, I trust your judgement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #151
I pinned to 1.0.62 as v2 is not considered stable by the devs of JuliaFormatter. Also, JET loosened the JuliaSyntax requirement to "1, 2" so this should still play nicely with JET i believe