Generalize string handling

Author: Wynand

src/class.jl

@@ -38,7 +38,7 @@ end
 
 function Class(str::AbstractString, regions::AbstractSet{<:AbstractString})
     class = Class(:NONE)
-    occursin(FIXED_TIME_ZONE_REGEX, String(str)) && (class |= Class(:FIXED))
+    occursin(FIXED_TIME_ZONE_REGEX, str) && (class |= Class(:FIXED))
     !isempty(intersect(regions, TZData.STANDARD_REGIONS)) && (class |= Class(:STANDARD))
     !isempty(intersect(regions, TZData.LEGACY_REGIONS)) && (class |= Class(:LEGACY))
     return class

src/types/timezone.jl

@@ -64,18 +64,16 @@ US/Pacific (UTC-8/UTC-7)
 """
 TimeZone(::AbstractString, ::Class)
 
-TimeZone(str::AbstractString, args...) = TimeZone(String(str), args...)
-
-function TimeZone(str::String, mask::Class=Class(:DEFAULT))
+function TimeZone(str::AbstractString, mask::Class=Class(:DEFAULT))
     # Note: If the class `mask` does not match the time zone we'll still load the
     # information into the cache to ensure the result is consistent.
-    tz, class = get!(_tz_cache(), String(str)) do
-        tz_path = joinpath(TZData.COMPILED_DIR, split(String(str), "/")...)
+    tz, class = get!(_tz_cache(), str) do
+        tz_path = joinpath(TZData.COMPILED_DIR, split(str, "/")...)
 
         if isfile(tz_path)
             open(deserialize, tz_path, "r")
-        elseif occursin(FIXED_TIME_ZONE_REGEX, String(str))
-            FixedTimeZone(String(str)), Class(:FIXED)
+        elseif occursin(FIXED_TIME_ZONE_REGEX, str)
+            FixedTimeZone(str), Class(:FIXED)
         elseif !isdir(TZData.COMPILED_DIR) || isempty(readdir(TZData.COMPILED_DIR))
             # Note: Julia 1.0 supresses the build logs which can hide issues in time zone
             # compliation which result in no tzdata time zones being available.
@@ -119,7 +117,7 @@ Check whether a string is a valid for constructing a `TimeZone` with the provide
 """
 function istimezone(str::AbstractString, mask::Class=Class(:DEFAULT))
     # Start by performing quick FIXED class test
-    if mask & Class(:FIXED) != Class(:NONE) && occursin(FIXED_TIME_ZONE_REGEX, String(str))
+    if mask & Class(:FIXED) != Class(:NONE) && occursin(FIXED_TIME_ZONE_REGEX, str)
         return true
     end