fix: enable --ensure-no-loss false flag to disable functionality (#187)

* fix: enable --ensure-no-loss false flag to disable functionality

- Update option definition to accept [value] parameter in both kysor and protocol
- Change default from boolean true to string "true" for proper parsing
- Fix kysor.ts logic to properly handle false case by passing --ensure-no-loss false
- Add proper type normalization to handle both string and boolean types
- Update version numbers in package.json files

This completes the fix for ensureNoLoss flag, allowing users to disable
the functionality by passing --ensure-no-loss false.

* Bump version to 1.4.1 in package.json

Author: Liver-23

common/protocol/src/index.ts

@@ -330,9 +330,9 @@ export class Validator {
         "0"
       )
       .option(
-        "--ensure-no-loss",
-        "Ensures that the node only uploads bundles which can be fully rewarded by the protocol.",
-        true
+        "--ensure-no-loss [value]",
+        "Ensures that the node only uploads bundles which can be fully rewarded by the protocol. Set to 'false' to disable [default = true]",
+        "true"
       )
       .option(
         "--scale-ensure-no-loss <number>",

common/protocol/src/version.ts

@@ -1 +1 @@
-export const PROTOCOL_VERSION = "1.5.0";
+export const PROTOCOL_VERSION = "1.6.1";

tools/kysor/package.json

@@ -25,9 +25,10 @@
   },
   "bin": "./dist/src/index.js",
   "pkg": {
-    "scripts": "./dist/index.js",
+    "scripts": "./dist/src/index.js",
     "assets": [
-      "../../node_modules/classic-level/**/*"
+      "../../node_modules/classic-level/**/*",
+      "../../node_modules/axios/**/*"
     ],
     "targets": [
       "latest-linux-x64",

tools/kysor/src/commands/start.ts

@@ -29,9 +29,9 @@ start
     "The gas price the node should use to calculate transaction fees, this value will be loaded by default based on the chain id"
   )
   .option(
-    "--ensure-no-loss",
-    "Ensures that the node only uploads bundles which can be fully rewarded by the protocol.",
-    true
+    "--ensure-no-loss [value]",
+    "Ensures that the node only uploads bundles which can be fully rewarded by the protocol. Set to 'false' to disable [default = true]",
+    "true"
   )
   .option(
     "--scale-ensure-no-loss <number>",

tools/kysor/src/kysor.ts

@@ -404,11 +404,23 @@ export const run = async (options: any) => {
         `${versionHome}`,
       ];
 
-      if (JSON.parse(options.ensureNoLoss)) {
+      // Handle ensure-no-loss option: support --ensure-no-loss false to disable
+      // Normalize the value to handle both string and boolean types
+      let ensureNoLossValue: string;
+      if (options.ensureNoLoss === undefined) {
+        ensureNoLossValue = "true";
+      } else if (typeof options.ensureNoLoss === "boolean") {
+        ensureNoLossValue = options.ensureNoLoss ? "true" : "false";
+      } else {
+        ensureNoLossValue = String(options.ensureNoLoss).toLowerCase();
+      }
+      
+      if (ensureNoLossValue === "false") {
         args.push("--ensure-no-loss");
+        args.push("false");
       } else {
+        // For true or default case, just pass the flag (defaults to true)
         args.push("--ensure-no-loss");
-        args.push(`${false}`);
       }
 
       if (options.scaleEnsureNoLoss > 0) {