Merge pull request #285 from Kit/lint-code-php7.1

Run PHPStan against PHP 7.1+

Author: n7studios

.github/workflows/coding-standards.yml

@@ -151,5 +151,4 @@ jobs:
       # Run PHPStan for static analysis.
       - name: Run PHPStan Static Analysis
         working-directory: ${{ env.PLUGIN_DIR }}
-        if: ${{ contains('8.0 8.1 8.2 8.3 8.4', matrix.php-versions) }}
         run: php vendor/bin/phpstan analyse --memory-limit=1024M

phpstan-dev.neon

@@ -6,6 +6,11 @@ includes:
 
 # Parameters
 parameters:
+    # Analyse against the minimum supported PHP version.
+    # This flags features (union types, enums, str_contains, etc.) that would
+    # fail on older PHP versions regardless of which PHP version PHPStan runs on.
+    phpVersion: 70100
+
     # Paths to scan
     # This should comprise of the base Plugin PHP file, plus directories that contain Plugin PHP files
     paths:
@@ -25,11 +30,17 @@ parameters:
     scanFiles:
         - /wp/wp-config.php
 
-    # Should not need to edit anything below here
-    # Rule Level: https://phpstan.org/user-guide/rule-levels
-    level: 5
+    # Don't report unmatched ignored errors on older PHP versions (7.2, 7.3)
+    reportUnmatchedIgnoredErrors: false
 
     # Ignore the following errors, as PHPStan and PHPStan for WordPress haven't registered symbols for them yet,
     # so they're false positives.
     ignoreErrors:
-        - '#Call to an undefined method WC_Order_Item::get_product\(\).#'
+        - '#unknown class WC_Session_Handler#'
+        - '#unknown class WC_Order_Item#'
+        - '#Call to an undefined method WC_Order_Item::get_product\(\).#'
+        - '#No error to ignore is reported#'
+
+    # Should not need to edit anything below here
+    # Rule Level: https://phpstan.org/user-guide/rule-levels
+    level: 5

phpstan.neon.dist

@@ -6,6 +6,11 @@ includes:
 
 # Parameters
 parameters:
+    # Analyse against the minimum supported PHP version.
+    # This flags features (union types, enums, str_contains, etc.) that would
+    # fail on older PHP versions regardless of which PHP version PHPStan runs on.
+    phpVersion: 70100
+
     # Paths to scan
     # This should comprise of the base Plugin PHP file, plus directories that contain Plugin PHP files
     paths:
@@ -25,11 +30,17 @@ parameters:
     scanFiles:
         - /home/runner/work/convertkit-woocommerce/convertkit-woocommerce/wordpress/wp-config.php
 
-    # Should not need to edit anything below here
-    # Rule Level: https://phpstan.org/user-guide/rule-levels
-    level: 5
+    # Don't report unmatched ignored errors on older PHP versions (7.2, 7.3)
+    reportUnmatchedIgnoredErrors: false
 
     # Ignore the following errors, as PHPStan and PHPStan for WordPress haven't registered symbols for them yet,
     # so they're false positives.
     ignoreErrors:
-        - '#Call to an undefined method WC_Order_Item::get_product\(\).#'
+        - '#unknown class WC_Session_Handler#'
+        - '#unknown class WC_Order_Item#'
+        - '#Call to an undefined method WC_Order_Item::get_product\(\).#'
+        - '#No error to ignore is reported#'
+
+    # Should not need to edit anything below here
+    # Rule Level: https://phpstan.org/user-guide/rule-levels
+    level: 5

phpstan.neon.example

@@ -6,6 +6,11 @@ includes:
 
 # Parameters
 parameters:
+    # Analyse against the minimum supported PHP version.
+    # This flags features (union types, enums, str_contains, etc.) that would
+    # fail on older PHP versions regardless of which PHP version PHPStan runs on.
+    phpVersion: 70100
+
     # Paths to scan
     # This should comprise of the base Plugin PHP file, plus directories that contain Plugin PHP files
     paths:
@@ -25,11 +30,17 @@ parameters:
     scanFiles:
         - /home/runner/work/convertkit-woocommerce/convertkit-woocommerce/wordpress/wp-config.php
 
-    # Should not need to edit anything below here
-    # Rule Level: https://phpstan.org/user-guide/rule-levels
-    level: 5
+    # Don't report unmatched ignored errors on older PHP versions (7.2, 7.3)
+    reportUnmatchedIgnoredErrors: false
 
     # Ignore the following errors, as PHPStan and PHPStan for WordPress haven't registered symbols for them yet,
     # so they're false positives.
     ignoreErrors:
-        - '#Call to an undefined method WC_Order_Item::get_product\(\).#'
+        - '#unknown class WC_Session_Handler#'
+        - '#unknown class WC_Order_Item#'
+        - '#Call to an undefined method WC_Order_Item::get_product\(\).#'
+        - '#No error to ignore is reported#'
+
+    # Should not need to edit anything below here
+    # Rule Level: https://phpstan.org/user-guide/rule-levels
+    level: 5