Skip to content

Commit bf4da39

Browse files
committed
docs(lil-gui): replace gui.remove(controller) with controller.destroy()
1 parent da154cf commit bf4da39

File tree

3 files changed

+10
-10
lines changed
  • Sources
    • IO/Geometry/GLTFImporter/example
    • Interaction/Animations/TimeStepBasedAnimationHandler/example
    • Rendering/Core/VolumeMapper/example

3 files changed

+10
-10
lines changed

Sources/IO/Geometry/GLTFImporter/example/index.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ function ready() {
170170
mixer = reader.getAnimationMixer();
171171
const names = animations.map((a) => a.id);
172172
params.Animation = names[0];
173-
controllers.Animation && gui.remove(controllers.Animation);
173+
controllers.Animation && controllers.Animation.destroy();
174174
controllers.Animation = gui
175175
.add(params, 'Animation', names)
176176
.name('Animation')
@@ -185,7 +185,7 @@ function ready() {
185185
const cameras = reader.getCameras();
186186
if (cameras.length) {
187187
params.Camera = cameras[0];
188-
controllers.Camera && gui.remove(controllers.Camera);
188+
controllers.Camera && controllers.Camera.destroy();
189189
controllers.Camera = gui
190190
.add(params, 'Camera', cameras)
191191
.name('Camera')
@@ -197,7 +197,7 @@ function ready() {
197197

198198
const scenes = reader.getScenes();
199199
if (scenes.length > 1) {
200-
controllers.Scene && gui.remove(controllers.Scene);
200+
controllers.Scene && controllers.Scene.destroy();
201201
controllers.Scene = gui
202202
.add(params, 'Scene', [...Array(scenes.length).keys()])
203203
.name('Scene')
@@ -208,7 +208,7 @@ function ready() {
208208

209209
const variants = reader.getVariants();
210210
if (variants.length > 1) {
211-
controllers.Variant && gui.remove(controllers.Variant);
211+
controllers.Variant && controllers.Variant.destroy();
212212
controllers.Variant = gui
213213
.add(params, 'Variant', [...Array(variants.length).keys()])
214214
.name('Variant')
@@ -242,7 +242,7 @@ fetch(`${baseUrl}/${modelsFolder}/model-index.json`)
242242
const dhModelIdx = modelsNames.indexOf('DamagedHelmet');
243243
selectedModel = userParms.model || modelsNames[dhModelIdx];
244244
params.Model = selectedModel;
245-
controllers.Model && gui.remove(controllers.Model);
245+
controllers.Model && controllers.Model.destroy();
246246
controllers.Model = gui
247247
.add(params, 'Model', modelsNames)
248248
.name('Model')
@@ -254,7 +254,7 @@ fetch(`${baseUrl}/${modelsFolder}/model-index.json`)
254254

255255
selectedFlavor = userParms.flavor || variants[0];
256256
params.Flavor = selectedFlavor;
257-
controllers.Flavor && gui.remove(controllers.Flavor);
257+
controllers.Flavor && controllers.Flavor.destroy();
258258
controllers.Flavor = gui
259259
.add(params, 'Flavor', variants)
260260
.name('Flavor')

Sources/Interaction/Animations/TimeStepBasedAnimationHandler/example/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ const gui = new GUI();
2727
const params = { TimeIndex: 0 };
2828
let timeCtrl;
2929
function initialiseSelector(steps, applyStep) {
30-
if (timeCtrl) gui.remove(timeCtrl);
30+
if (timeCtrl) timeCtrl.destroy();
3131
timeCtrl = gui
3232
.add(params, 'TimeIndex', 0, steps.length - 1, 1)
3333
.name('Time step index')

Sources/Rendering/Core/VolumeMapper/example/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ const setColorMixPreset = (presetKey) => {
162162
};
163163

164164
function rebuildForceNearestControllers(comp) {
165-
forceNearestControllers.forEach((c) => gui.remove(c));
165+
forceNearestControllers.forEach((c) => c.destroy());
166166
forceNearestControllers = [];
167167
for (let i = 0; i < comp; ++i) {
168168
const obj = {
@@ -230,7 +230,7 @@ reader.setUrl(`${__BASE_PATH__}/data/volume/LIDC2.vti`).then(() => {
230230

231231
const volumeKeys = Object.keys(volumeOptions);
232232
params.Volume = volumeKeys[0];
233-
if (volumeController) gui.remove(volumeController);
233+
if (volumeController) volumeController.destroy();
234234
volumeController = gui
235235
.add(params, 'Volume', volumeKeys)
236236
.name('Volume')
@@ -301,7 +301,7 @@ gui
301301
renderWindow.render();
302302
});
303303

304-
if (presetController) gui.remove(presetController);
304+
if (presetController) presetController.destroy();
305305
presetController = gui
306306
.add(params, 'Preset', presetKeys)
307307
.name('Preset')

0 commit comments

Comments
 (0)