Skip to content

fix(datasetattributes): Fix active attribute assignment #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(datasetattributes): Fix active attribute assignment #3347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions Sources/Common/DataModel/DataSetAttributes/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,17 +61,9 @@ function vtkDataSetAttributes(publicAPI, model) {
);
return -1;
}
let currentAttribute = model[`active${attType}`];
if (currentAttribute >= 0 && currentAttribute < model.arrays.length) {
if (model.arrays[currentAttribute] === arr) {
return currentAttribute;
}
// FIXME setting an array actually changes its index
publicAPI.removeArrayByIndex(currentAttribute);
}

if (arr) {
currentAttribute = publicAPI.addArray(arr);
const currentAttribute = publicAPI.addArray(arr);
model[`active${attType}`] = currentAttribute;
} else {
model[`active${attType}`] = -1;
Expand Down