[ZCL] Move custom clusters to ZHC

[Nerivec]

Tracking the list of remaining custom clusters to move to ZHC, if anyone wants to tackle some!
We'll mark priority ones (ID conflict) as we encounter them.

TODO:

• custom attributes and commands within standard clusters (too many to list here...)
• manuSpecificTuya
• manuSpecificTuya2
• manuSpecificTuya3
• manuSpecificSinope
• manuSpecificLumi
• manuSpecificSmartThingsArrivalSensor
• manuSpecificSiglisZigfred
• owonClearMetering
• zosungIRTransmit
• zosungIRControl
• manuSpecificProfalux1
• manuSpecificPhilips*
  • priority, conflict with yet-to-be-moved manuSpecificAssaDoorLock
• manuSpecificPhilips2
• manuSpecificSamsungAccelerometer
  • priority, several manufacturer codes used for same cluster, must declare per-code for proper "default" behavior
• manuSpecificClusterAduroSmart
• manuSpecificOsram
• manuSpecificLegrandDevices
• manuSpecificLegrandDevices2
• manuSpecificLegrandDevices3
• wiserDeviceInfo
• manuSpecificCentraliteHumidity
• tradfriButton
• schneiderSpecificPilotMode
• elkoOccupancySettingClusterServer
• elkoSwitchConfigurationClusterServer*
  • priority, conflict with yet-to-be-moved manuSpecificSchneiderLightSwitchConfiguration
• manuSpecificSchneiderLightSwitchConfiguration*
  • priority, conflict with yet-to-be-moved elkoSwitchConfigurationClusterServer
• manuSpecificSchneiderFanSwitchConfiguration
• sprutVoc
  • priority, not using the proper "custom" range
• sprutNoise
  • priority, not using the proper "custom" range
• sprutIrBlaster
  • priority, not using the proper "custom" range
• manuSpecificAssaDoorLock*
  • priority, conflict with yet-to-be-moved manuSpecificPhilips (and apparently some other yet-to-be-supported devices)
• manuSpecificDoorman
• manuSpecificAmazonWWAH (kept in ZH due to "global" usage)

*: can optimize lookup performance in ZH once these are moved (no more cluster ID tied to multiple names)

Note: some have manufacturer code ties, so, the conflicts with other "yet-to-be-moved" should technically be mitigated, but still marked as priority.

And also plenty of custom attributes in regular ZCL clusters. These were moved and marked under // custom in each cluster in a recent PR for quick identification.

https://github.com/Koenkk/zigbee-herdsman/blob/master/src/zspec/zcl/definition/cluster.ts

You can find some example moves by looking at the additions in ZHC:
https://github.com/search?q=repo%3AKoenkk%2Fzigbee-herdsman-converters+deviceAddCustomCluster+path%3Asrc&type=code

[burmistrzak]

I'll take a look at the Hue stuff.

[burmistrzak]

@Nerivec Any idea what's going on here? Another custom cluster with overlapping ID? 🤔

I'm currently trying to identify all devices that use manuSpecificPhilips and manuSpecificPhilips2...

[Nerivec]

Could be using the same attribute or something. Or could be an error. This definition is very old (dates back to before TS).
Koenkk/zigbee-herdsman-converters#4560

[burmistrzak]

Could be using the same attribute or something. Or could be an error. This definition is very old (dates back to before TS). Koenkk/zigbee-herdsman-converters#4560

Guess that's getting yoinked then! 😁

[svhelge]

Created PR #1650 , "Remove elkoOccupancySettingClusterServer, already implemented in ZHC"

[svhelge]

Created PR #1652, "Remove elkoSwitchConfigurationClusterServer, not used in ZHC"

[svhelge]

The manuSpecificDoorman cluster is not used in ZHC. Should the cluster be moved to yale.ts or simply removed?

[Nerivec]

@svhelge looks like it came from #653 and Koenkk/zigbee2mqtt#4778 (for ZYA-C4-MOD-S). Might want to investigate if the device is missing the cluster impl. (& thus should be added), or if it was added from spec or something but not actually needed.
CC: @danieledwardgeorgehitchcock

[svhelge]

Created Koenkk/zigbee-herdsman-converters#11586 and #1654 - move manuSpecificSchneiderLightSwitchConfiguration from ZH to ZHC.

[danieledwardgeorgehitchcock]

@svhelge looks like it came from #653 and Koenkk/zigbee2mqtt#4778 (for ZYA-C4-MOD-S). Might want to investigate if the device is missing the cluster impl. (& thus should be added), or if it was added from spec or something but not actually needed. CC: @danieledwardgeorgehitchcock

Hey! I did indeed create the manuSpecificDoorman cluster while under the hood reversing the Control4 LUA driver. While I didn't use it in my specific implementation of the driver (I was focused more on the KeyFree / Conexis range of devices), I backported the Doorman stuff where I could to assist in the efforts of others to implement the converter for the Doorman range