[GeoMechanicsApplication] Move all non-template code to .cpp files and make sure any .h file does not contain any implementations (strategies) (#14115)

* renamed residualbased_block_builder_and_solver_with_mass_and_damping.h

* removed 5 code smells

Author: markelov208

applications/GeoMechanicsApplication/custom_python/add_custom_strategies_to_python.cpp

@@ -24,7 +24,7 @@
 #include "solving_strategies/strategies/solving_strategy.h"
 
 // builders and solvers
-#include "custom_strategies/builder_and_solvers/residualbased_block_builder_and_solver_with_mass_and_damping.h"
+#include "custom_strategies/builder_and_solvers/residualbased_block_builder_and_solver_with_mass_and_damping.hpp"
 
 // schemes
 #include "custom_strategies/schemes/backward_euler_T_scheme.hpp"

…ilder_and_solver_with_mass_and_damping.h …der_and_solver_with_mass_and_damping.hppapplications/GeoMechanicsApplication/custom_strategies/builder_and_solvers/residualbased_block_builder_and_solver_with_mass_and_damping.h renamed to applications/GeoMechanicsApplication/custom_strategies/builder_and_solvers/residualbased_block_builder_and_solver_with_mass_and_damping.hpp applications/GeoMechanicsApplication/custom_strategies/builder_and_solvers/residualbased_block_builder_and_solver_with_mass_and_damping.h renamed to applications/GeoMechanicsApplication/custom_strategies/builder_and_solvers/residualbased_block_builder_and_solver_with_mass_and_damping.hpp

@@ -378,7 +378,7 @@ class ResidualBasedBlockBuilderAndSolverWithMassAndDamping
         BuildRHSNoDirichlet(pScheme, rModelPart, rb);
 
         // NOTE: dofs are assumed to be numbered consecutively in the BlockBuilderAndSolver
-        block_for_each(BaseType::mDofSet, [&](Dof<double>& r_dof) {
+        block_for_each(BaseType::mDofSet, [&rb](const Dof<double>& r_dof) {
             if (r_dof.IsFixed()) {
                 const std::size_t i = r_dof.EquationId();
                 rb[i]               = 0.0;
@@ -396,7 +396,7 @@ class ResidualBasedBlockBuilderAndSolverWithMassAndDamping
      */
     Parameters GetDefaultParameters() const override
     {
-        Parameters default_parameters = Parameters(R"(
+        auto default_parameters = Parameters(R"(
         {
             "name"                                 : "block_builder_and_solver_with_mass_and_damping",
             "block_builder"                        : true,
@@ -520,11 +520,11 @@ class ResidualBasedBlockBuilderAndSolverWithMassAndDamping
 
         // assemble all elements
 
-        const int nelements = static_cast<int>(r_elements.size());
-#pragma omp parallel firstprivate(nelements, rhs_contribution, equation_ids)
+        const auto n_elements = static_cast<int>(r_elements.size());
+#pragma omp parallel firstprivate(n_elements, rhs_contribution, equation_ids)
         {
 #pragma omp for schedule(guided, 512) nowait
-            for (int i = 0; i < nelements; i++) {
+            for (int i = 0; i < n_elements; i++) {
                 typename ElementsArrayType::iterator it = r_elements.begin() + i;
                 // If the element is active
                 if (it->IsActive()) {
@@ -540,9 +540,9 @@ class ResidualBasedBlockBuilderAndSolverWithMassAndDamping
             rhs_contribution.resize(0, false);
 
             // assemble all conditions
-            const int nconditions = static_cast<int>(r_conditions.size());
+            const auto n_conditions = static_cast<int>(r_conditions.size());
 #pragma omp for schedule(guided, 512)
-            for (int i = 0; i < nconditions; i++) {
+            for (int i = 0; i < n_conditions; i++) {
                 auto it = r_conditions.begin() + i;
                 // If the condition is active
                 if (it->IsActive()) {