PR 49 breaks ProtoDUNE-SP reconstruction regression test -- data products have zero-length collections for TPC

[tomjunk]

PR #49 causes the sizes of many reconstruction data product vectors to be zero in the CI test:

ci_test_datareco_protoDUNEsp.fcl

with input file:

xroot://fndca1.fnal.gov:1095/pnfs/fnal.gov/usr/dune/persistent/stash/ContinuousIntegration/protoDUNEsp/datareco/np04_raw_run005809_0004_dl6.root

Enclosed are the outputs of eventdump.fcl on a single reco event from the above test, and also with PR #49 reverted, contained in PR #50.

larsoftv10_03_00_revert49.txt
larsoftv10_03_00_with_larwirecell_v10_01_00.txt

[tomjunk]

Even though recob::Wire appears in both eventdump outputs, the one with PR49 contains only lines like these:

Event run: 5809 subRun: 1 event: 4503 contains 15360 'wclsdatasp:gauss' wires
channel #0 on view U; 6000 time ticks with nothing in them
channel #1 on view U; 6000 time ticks with nothing in them
channel #2 on view U; 6000 time ticks with nothing in them
channel #3 on view U; 6000 time ticks with nothing in them
channel #4 on view U; 6000 time ticks with nothing in them
channel #5 on view U; 6000 time ticks with nothing in them
...

whereas the reverted version contains lines like these:

Event run: 5809 subRun: 1 event: 4503 contains 15360 'wclsdatasp:gauss' wires
channel #0 on view U; 6000 time ticks with 4 regions of interest:
from 4541 for 3 ticks
from 4546 for 28 ticks
from 4579 for 28 ticks
from 4618 for 23 ticks
content of the wire (20 ticks per line):
0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000
[ ... repeated 226 more times, 4520 ticks ]
0.000 0.064 0.074 0.027 0.000 0.000 0.075 0.323 0.554 0.642 0.602 0.559 0.599 0.681 0.726 0.743 0.824 1.016 1.231 1.329
1.261 1.105 0.968 0.871 0.761 0.596 0.406 0.260 0.197 0.198 0.209 0.183 0.116 0.042 0.000 0.000 0.000 0.000 0.000 0.076
0.218 0.359 0.439 0.460 0.478 0.555 0.724 0.997 1.356 1.765 2.186 2.587 2.917 3.099 3.079 2.888 2.620 2.340 2.040 1.700
1.367 1.122 0.977 0.846 0.636 0.361 0.122 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.020 0.196
0.541 0.995 1.491 2.013 2.552 3.041 3.354 3.390 3.153 2.729 2.218 1.692 1.209 0.814 0.528 0.339 0.213 0.125 0.068 0.033
0.012 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000
0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000 0.000
[ ... repeated 66 more times to the end ]
range of 6000 samples: [0.000;3.390]