Skip to content

Commit 2832ba7

Browse files
Checkpoint FileLike migration
1 parent ff37156 commit 2832ba7

File tree

2 files changed

+7
-14
lines changed

2 files changed

+7
-14
lines changed

genotyping/src/org/labkey/genotyping/HaplotypeAssayProvider.java

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646
import org.labkey.api.assay.AssayUrls;
4747
import org.labkey.api.study.assay.ParticipantVisitResolverType;
4848
import org.labkey.api.util.FileType;
49+
import org.labkey.api.util.HtmlString;
4950
import org.labkey.api.util.PageFlowUtil;
5051
import org.labkey.api.util.Pair;
5152
import org.labkey.api.view.ActionURL;
@@ -135,7 +136,7 @@ public String getName()
135136
@Override
136137
public HttpView<?> getDataDescriptionView(AssayRunUploadForm form)
137138
{
138-
return new HtmlView("");
139+
return new HtmlView(HtmlString.EMPTY_STRING);
139140
}
140141

141142
@Override
@@ -205,26 +206,18 @@ protected Map<String, Set<String>> getRequiredDomainProperties()
205206
{
206207
Map<String, Set<String>> domainMap = super.getRequiredDomainProperties();
207208

208-
Set<String> runProperties = domainMap.get(ExpProtocol.ASSAY_DOMAIN_RUN);
209-
if (runProperties == null)
210-
{
211-
runProperties = new HashSet<>();
212-
domainMap.put(ExpProtocol.ASSAY_DOMAIN_RUN, runProperties);
213-
}
209+
Set<String> runProperties = domainMap.computeIfAbsent(ExpProtocol.ASSAY_DOMAIN_RUN, k -> new HashSet<>());
214210
runProperties.add(ENABLED_PROPERTY_NAME);
215-
for (String propName : getColumnMappingProperties(true).keySet())
216-
{
217-
runProperties.add(propName);
218-
}
211+
runProperties.addAll(getColumnMappingProperties(true).keySet());
219212
runProperties.add(SPECIES_COLUMN.getName());
220213

221214
return domainMap;
222215
}
223216

224217
@Override
225-
public List<AssayDataCollector> getDataCollectors(@Nullable Map<String, File> uploadedFiles, AssayRunUploadForm context)
218+
public List<AssayDataCollector> getDataCollectors(@Nullable Map<String, org.labkey.vfs.FileLike> uploadedFiles, AssayRunUploadForm context)
226219
{
227-
return Collections.singletonList(new HaplotypeDataCollector());
220+
return Collections.singletonList(new HaplotypeDataCollector<>());
228221
}
229222

230223
@Override

genotyping/src/org/labkey/genotyping/HaplotypeDataCollector.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public class HaplotypeDataCollector<ContextType extends AssayRunUploadContext<Ha
4343
private Map<String, String> _reshowMap;
4444

4545
@Override
46-
public HttpView getView(ContextType context)
46+
public HttpView<?> getView(ContextType context)
4747
{
4848
// if reshowing on error, get the data param out of the context for the JSP to use
4949
HttpServletRequest request = context.getRequest();

0 commit comments

Comments
 (0)