Skip to content

Commit f0eb407

Browse files
committed
Return Set<Class<?>> from Module "get test" methods
1 parent d3b5310 commit f0eb407

File tree

5 files changed

+8
-12
lines changed

5 files changed

+8
-12
lines changed

OConnorExperiments/src/org/labkey/oconnorexperiments/view/history.jsp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,8 @@
2424
<%@ page import="org.labkey.api.query.QueryView" %>
2525
<%@ page import="org.labkey.api.query.UserSchema" %>
2626
<%@ page import="org.labkey.api.security.User" %>
27-
<%@ page import="org.labkey.api.services.ServiceRegistry" %>
2827
<%@ page import="org.labkey.api.view.ViewContext" %>
2928
<%@ page import="org.labkey.api.view.WebPartView" %>
30-
<%@ page import="org.labkey.api.view.template.ClientDependencies" %>
3129
<%@ page import="org.labkey.api.wiki.WikiService" %>
3230
<%@ page import="org.labkey.oconnorexperiments.query.OConnorExperimentsUserSchema" %>
3331
<%@ page extends="org.labkey.api.jsp.JspBase" %>
@@ -86,7 +84,7 @@
8684
<h3>Notes History</h3>
8785
<%
8886
{
89-
WebPartView view = WikiService.get().getHistoryView(c, "default");
87+
WebPartView<?> view = WikiService.get().getHistoryView(c, "default");
9088
if (view != null)
9189
include(view, out);
9290
}

genotyping/src/org/labkey/genotyping/GenotypingAnalysesView.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ public class GenotypingAnalysesView extends QueryView
4141
public static final WebPartFactory FACTORY = new BaseWebPartFactory("Genotyping Analyses")
4242
{
4343
@Override
44-
public WebPartView getWebPartView(@NotNull ViewContext ctx, @NotNull Portal.WebPart webPart)
44+
public WebPartView<?> getWebPartView(@NotNull ViewContext ctx, @NotNull Portal.WebPart webPart)
4545
{
46-
WebPartView view = new GenotypingAnalysesView(ctx, null, "GenotypingAnalyses");
46+
WebPartView<?> view = new GenotypingAnalysesView(ctx, null, "GenotypingAnalyses");
4747
view.setTitle("Genotyping Analyses");
4848
view.setTitleHref(GenotypingController.getAnalysesURL(ctx.getContainer()));
4949
return view;

genotyping/src/org/labkey/genotyping/GenotypingModule.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -140,16 +140,14 @@ public Set<String> getSchemaNames()
140140
return Collections.singleton(GenotypingSchema.get().getSchemaName());
141141
}
142142

143-
@NotNull
144143
@Override
145-
public Set<Class> getUnitTests()
144+
public @NotNull Set<Class<?>> getUnitTests()
146145
{
147146
return PageFlowUtil.set(HaplotypeDataHandler.TestCase.class, IlluminaFastqParser.DupeTestCase.class);
148147
}
149148

150-
@NotNull
151149
@Override
152-
public Set<Class> getIntegrationTests()
150+
public @NotNull Set<Class<?>> getIntegrationTests()
153151
{
154152
return PageFlowUtil.set(IlluminaFastqParser.HeaderTestCase.class, ImportAnalysisJob.TestCase.class);
155153
}

genotyping/src/org/labkey/genotyping/GenotypingRunsView.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ public class GenotypingRunsView extends QueryView
4242
public static final WebPartFactory FACTORY = new BaseWebPartFactory("Sequencing Runs")
4343
{
4444
@Override
45-
public WebPartView getWebPartView(@NotNull ViewContext ctx, @NotNull Portal.WebPart webPart)
45+
public WebPartView<?> getWebPartView(@NotNull ViewContext ctx, @NotNull Portal.WebPart webPart)
4646
{
47-
WebPartView view = new GenotypingRunsView(ctx, null, "SequencingRuns", false);
47+
WebPartView<?> view = new GenotypingRunsView(ctx, null, "SequencingRuns", false);
4848
view.setTitle("Sequencing Runs");
4949
view.setTitleHref(GenotypingController.getRunsURL(ctx.getContainer()));
5050
return view;

genotyping/src/org/labkey/genotyping/GenotypingWebPart.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public class GenotypingWebPart extends JspView
3636
public static final WebPartFactory FACTORY = new BaseWebPartFactory("Genotyping Overview")
3737
{
3838
@Override
39-
public WebPartView getWebPartView(@NotNull ViewContext portalCtx, @NotNull Portal.WebPart webPart)
39+
public WebPartView<?> getWebPartView(@NotNull ViewContext portalCtx, @NotNull Portal.WebPart webPart)
4040
{
4141
return new GenotypingWebPart();
4242
}

0 commit comments

Comments
 (0)