DatabaseIdentifier (#937)

* DatabaseIdentifier
ColumnInfo.getAlias()
ColumnInfo.getSelectName()

* cleanup

---------

Co-authored-by: Marty Pradere <martyp@labkey.com>
Co-authored-by: Adam Rauch <adam@labkey.com>

Author: 3 people

ehr/api-src/org/labkey/api/ehr/demographics/AbstractDemographicsProvider.java

@@ -116,16 +116,10 @@ public Map<String, Map<String, Object>> getProperties(DefaultSchema defaultSchem
             public void exec(ResultSet object) throws SQLException
             {
                 Results rs = new ResultsImpl(object, cols);
+                String id = ti.getColumn("Id").getStringValue(rs);
 
-                String id = rs.getString(FieldKey.fromString(ti.getColumn("Id").getAlias()));
-
-                Map<String, Object> map = ret.get(id);
-                if (map == null)
-                    map = new TreeMap<>();
-
+                Map<String, Object> map = ret.computeIfAbsent(id, (x)->new TreeMap<>());
                 processRow(rs, cols, map);
-
-                ret.put(id, map);
             }
         });
         if (debugEnabled)

ehr/api-src/org/labkey/api/ehr/demographics/WeightsDemographicsProvider.java

@@ -85,16 +85,10 @@ public Map<String, Map<String, Object>> getProperties(DefaultSchema defaultSchem
                 public void exec(ResultSet object) throws SQLException
                 {
                     Results rs = new ResultsImpl(object, cols);
+                    String id = ti.getColumn("Id").getStringValue(rs);
 
-                    String id = rs.getString(FieldKey.fromString(ti.getColumn("Id").getAlias()));
-
-                    Map<String, Object> map = ret.get(id);
-                    if (map == null)
-                        map = new HashMap<>();
-
+                    Map<String, Object> map = ret.computeIfAbsent(id, (x)->new HashMap<>());
                     processRow(rs, cols, map);
-
-                    ret.put(id, map);
                 }
             });
         }