CR feedback

Author: labkey-martyp

EHR_App/test/src/org/labkey/test/pages/ReactAnimalHistoryPage.java

@@ -362,6 +362,7 @@ public boolean isValidationErrorVisible()
      */
     public boolean isEmptyStatePlaceholderVisible()
     {
+        waitForElement(Locators.EMPTY_STATE_PLACEHOLDER);
         return isElementPresent(Locators.EMPTY_STATE_PLACEHOLDER);
     }
 
@@ -415,8 +416,8 @@ public static class Locators
         public static final Locator NOT_FOUND_SECTION_TITLE = Locator.css(".id-resolution-feedback .section-title.not-found");
         public static final Locator RESOLVED_ITEMS = Locator.css(".id-resolution-feedback .section .items .resolved-item");
         public static final Locator NOT_FOUND_ITEMS = Locator.css(".id-resolution-feedback .section .items .not-found-item");
-        public static final Locator CATEGORY_TAB = Locator.css(".tabbed-report-panel .category-tabs a");
-        public static final Locator REPORT_TAB = Locator.css(".tabbed-report-panel .report-tabs a");
+        public static final Locator CATEGORY_TAB = Locator.css(".tabbed-report-panel .category-tabs button");
+        public static final Locator REPORT_TAB = Locator.css(".tabbed-report-panel .report-tabs button");
         public static final Locator VALIDATION_ERROR = Locator.css(".search-by-id-panel .validation-error");
         public static final Locator EMPTY_STATE_PLACEHOLDER = Locator.css(".tabbed-report-panel .empty-state-placeholder");
     }

ehr/package-lock.json

@@ -17,7 +17,7 @@
   "dependencies": {
     "@labkey/api": "1.44.0",
     "@labkey/components": "6.72.1",
-    "@labkey/ehr": "0.0.4-fb-ehr-hist-id-search.5"
+    "@labkey/ehr": "0.0.4-fb-ehr-hist-id-search.7"
   },
   "devDependencies": {
     "@labkey/build": "8.7.0",

ehr/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@labkey/ehr",
-  "version": "0.0.4-fb-ehr-hist-id-search.5",
+  "version": "0.0.4-fb-ehr-hist-id-search.7",
   "description": "Components, models, actions, and utility functions for LabKey EHR applications and pages",
   "sideEffects": false,
   "files": [
@@ -29,7 +29,7 @@
     "clean": "rimraf dist",
     "cleanAll": "rimraf dist && rimraf node_modules",
     "prepublishOnly": "npm install --legacy-peer-deps && cross-env WEBPACK_STATS=errors-only npm run build",
-    "test": "cross-env NODE_ENV=test jest --maxWorkers=6 --silent",
+    "test": "cross-env NODE_ENV=test jest --maxWorkers=6",
     "test-ci": "cross-env NODE_ENV=test jest --ci --silent",
     "test-coverage": "cross-env NODE_ENV=test jest --maxWorkers=6 --coverage",
     "lint": "npx eslint",