Handle "undefined" href

labkey-martyp · labkey-martyp · commit c389b0754674 · 2025-07-30T15:39:24.000-07:00
diff --git a/ehr/test/src/org/labkey/test/tests/ehr/AbstractGenericEHRTest.java b/ehr/test/src/org/labkey/test/tests/ehr/AbstractGenericEHRTest.java
@@ -344,7 +344,7 @@ protected List<String> skipLinksForCrawling()
     private String validLink(WebElement anchor)
     {
         String href = anchor.getDomAttribute("href");
-        if (href != null && !href.startsWith("#"))
+        if (href != null && !href.startsWith("#") && !href.equalsIgnoreCase("undefined"))
         {
             String decodedHref = EscapeUtil.decodeUriPath(href);
             if (skipLinksForValidation().stream().anyMatch(s -> decodedHref.toLowerCase().contains(s.toLowerCase())))

Original file line number	Diff line number	Diff line change
`@@ -344,7 +344,7 @@ protected List<String> skipLinksForCrawling()`
`344`	`344`	`private String validLink(WebElement anchor)`
`345`	`345`	`{`
`346`	`346`	`String href = anchor.getDomAttribute("href");`
`347`		`- if (href != null && !href.startsWith("#"))`
	`347`	`+ if (href != null && !href.startsWith("#") && !href.equalsIgnoreCase("undefined"))`
`348`	`348`	`{`
`349`	`349`	`String decodedHref = EscapeUtil.decodeUriPath(href);`
`350`	`350`	`if (skipLinksForValidation().stream().anyMatch(s -> decodedHref.toLowerCase().contains(s.toLowerCase())))`