Use data-flagId attribute (#2466)

Author: labkey-adam

src/org/labkey/test/util/DataRegionTable.java

@@ -246,7 +246,7 @@ public int getColumnCount()
 
     public boolean hasSummaryStatisticRow()
     {
-        return Locator.css("tr.labkey-col-total").findElements(elementCache()).size() > 0;
+        return !Locator.css("tr.labkey-col-total").findElements(elementCache()).isEmpty();
     }
 
     /**
@@ -457,7 +457,7 @@ public int getColumnIndex(String name)
         if (i < 0)
         {
             List<String> columnLabelsWithoutSpaces = new ArrayList<>(getColumnLabels().size());
-            getColumnLabels().stream().forEach(s -> columnLabelsWithoutSpaces.add(s.replace(" ", "")));
+            getColumnLabels().forEach(s -> columnLabelsWithoutSpaces.add(s.replace(" ", "")));
             i = columnLabelsWithoutSpaces.indexOf(name.replace(" ", ""));
             if (i >= 0)
             {
@@ -825,7 +825,7 @@ public boolean hasHref(int row, String columnName)
     public WebElement getFlag(int row, String columnName)
     {
         var cell = findCell(row, columnName);
-        return tagWithAttribute("i", "flagid").findElement(cell);
+        return tagWithAttribute("i", "data-flagid").findElement(cell);
     }
 
     public boolean isFlagEnabled(int row, String columnName)
@@ -913,7 +913,7 @@ public void clearFlagValue(int row, String columnName)
      */
     public void clearFlagValues()
     {
-        List<WebElement> allFlags = Locator.tagWithAttribute("i", "flagid").findElements(elementCache());
+        List<WebElement> allFlags = Locator.tagWithAttribute("i", "data-flagid").findElements(elementCache());
         for (WebElement flag : allFlags)
         {
             if (isFlagEnabled(flag))