Support for instantiating tensors from num_complex::Complex values.#960
Open
metasim wants to merge 3 commits intoLaurentMazare:mainfrom
Open
Support for instantiating tensors from num_complex::Complex values.#960metasim wants to merge 3 commits intoLaurentMazare:mainfrom
num_complex::Complex values.#960metasim wants to merge 3 commits intoLaurentMazare:mainfrom
Conversation
Author
|
@LaurentMazare Any interest in this? I've been using it for almost 3 months without any problems. Would love to see it merged.... |
|
Any update missing from GH? This would be really useful :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I implemented this under a
complexfeature flag assuming this should be opt-in. However,ndarrayalready has a fixed dependency onnum-complexso there may be little benefit to doing so.Closes #959.