Skip to content

Commit b6eddeb

Browse files
committed
fix(test): fixes tests after merge with op-batcher/v1.15.0
* Increases `MaxFrameSize` in `ChannelConfig` used in AltDA tests * Removes invalid flags from kurtosis devent batcher config * Updates `DialRollupClientWithTimeout` args in `getClientsFromEndpoints` func in kurtosis-devnet harness.go
1 parent 414673a commit b6eddeb

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

kurtosis-devnet/eigenda.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,6 @@ optimism_package:
7979
- '{{ dig "batcher" "max-l1-tx-size-bytes" 1000 $context }}'
8080
- --batch-type
8181
- '{{ dig "batcher" "batch-type" 1 $context }}'
82-
- --throttle-threshold=500_000 # start throttling after 500KB of blocks backlog
83-
- --throttle-block-size=1000 # throttle op-geth blocks to 1000 gas
8482
proposer_params:
8583
image: {{ localDockerImage "op-proposer" }}
8684
extra_params: []

kurtosis-devnet/tests/eigenda/harness.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import (
1313
"time"
1414

1515
"github.com/Layr-Labs/eigenda-proxy/clients/memconfig_client"
16+
"github.com/ethereum-optimism/optimism/op-service/client"
1617
"github.com/ethereum-optimism/optimism/op-service/dial"
1718
"github.com/ethereum-optimism/optimism/op-service/sources"
1819
"github.com/ethereum-optimism/optimism/op-service/testlog"
@@ -192,7 +193,10 @@ type EnclaveServiceClients struct {
192193
}
193194

194195
func getClientsFromEndpoints(ctx context.Context, logger log.Logger, endpoints *EnclaveServicePublicEndpoints) (*EnclaveServiceClients, error) {
195-
opNodeClient, err := dial.DialRollupClientWithTimeout(ctx, 10*time.Second, logger, endpoints.OpNodeEndpoint)
196+
opts := []client.RPCOption{
197+
client.WithCallTimeout(10 * time.Second),
198+
}
199+
opNodeClient, err := dial.DialRollupClientWithTimeout(ctx, logger, endpoints.OpNodeEndpoint, opts...)
196200
if err != nil {
197201
return nil, fmt.Errorf("dial.DialRollupClientWithTimeout: %w", err)
198202
}

op-batcher/batcher/driver_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ func altDASetup(t *testing.T, log log.Logger) (*BatchSubmitter, *mockL2EndpointP
221221
// SeqWindowSize: 15,
222222
// SubSafetyMargin: 4,
223223
ChannelTimeout: 10,
224-
MaxFrameSize: 150, // so that each channel has exactly 1 frame
224+
MaxFrameSize: 300,
225225
TargetNumFrames: 1,
226226
BatchType: derive.SingularBatchType,
227227
CompressorConfig: compressor.Config{

0 commit comments

Comments
 (0)