fix: correct test_phase5.py to match actual module APIs

- Fix pin_detection test to use correct signature (board, color) not (board, move)
- Fix endgame tests to use public evaluate_endgame() method
- Opposition and key squares are tested via endgame evaluation (private methods)
- Tests now match actual working implementation from Phase 5

Author: LeonByte

test_phase5.py

@@ -43,14 +43,12 @@ def test_fork_detection_basic(self):
     def test_pin_detection(self):
         """Test pin detection"""
         board = chess.Board("r1bqkbnr/pppp1ppp/2n5/4p3/2B1P3/5N2/PPPP1PPP/RNBQK2R w KQkq - 0 1")
-        # Bishop on c4 pins knight on c6 to king on e8 (not directly, but test the mechanism)
+        # Bishop on c4 potentially pins pieces
 
-        # Test that pin detection runs without errors
-        move = chess.Move.from_uci("f3g5")
-        is_pin, value = self.tactical.detect_pin(board, move)
-        # Just verify it returns valid types
-        self.assertIsInstance(is_pin, bool)
-        self.assertIsInstance(value, (int, float))
+        # Test that pin detection runs without errors (returns list of pins)
+        pins = self.tactical.detect_pin(board, chess.BLACK)
+        # Just verify it returns valid type
+        self.assertIsInstance(pins, list)
 
     def test_tactical_urgency_evaluation(self):
         """Test overall tactical urgency evaluation"""
@@ -67,20 +65,22 @@ def setUp(self):
         self.endgame = EndgameMastery()
 
     def test_opposition_detection(self):
-        """Test opposition calculation"""
+        """Test opposition calculation (tested via evaluate_endgame)"""
         # King vs king endgame with opposition
         board = chess.Board("8/8/8/3k4/8/3K4/8/8 w - - 0 1")
 
-        bonus = self.endgame.evaluate_opposition(board, chess.WHITE)
-        self.assertIsInstance(bonus, int, "Opposition bonus should be integer")
+        # Opposition is evaluated internally by evaluate_endgame
+        bonus = self.endgame.evaluate_endgame(board, chess.WHITE)
+        self.assertIsInstance(bonus, int, "Endgame evaluation should be integer")
 
     def test_key_squares_evaluation(self):
-        """Test key square identification"""
+        """Test key square identification (tested via evaluate_endgame)"""
         # King and pawn endgame
         board = chess.Board("8/8/8/3k4/8/3KP3/8/8 w - - 0 1")
 
-        bonus = self.endgame.evaluate_key_squares(board, chess.WHITE)
-        self.assertIsInstance(bonus, int, "Key squares bonus should be integer")
+        # Key squares evaluated internally by evaluate_endgame
+        bonus = self.endgame.evaluate_endgame(board, chess.WHITE)
+        self.assertIsInstance(bonus, int, "Endgame evaluation should be integer")
 
     def test_endgame_evaluation(self):
         """Test overall endgame evaluation"""