Skip to content

Commit ba0983d

Browse files
committed
docs: fix component counts and add missing documentation
- Correct totals: 56 skills, 24 agents, 22 commands - Fix ring-default: 24 skills, 7 agents, 12 commands - Add missing agents: test-reviewer, nil-safety-reviewer - Add missing commands: interview-me, release-guide - Fix typo: ring:dev-ring:sre -> ring:dev-sre - Fix broken reference to non-existent docs/platforms/ - Update reviewer count from 3 to 5 in workflows X-Lerian-Ref: 0x1
1 parent c1f2207 commit ba0983d

4 files changed

Lines changed: 41 additions & 25 deletions

File tree

ARCHITECTURE.md

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ Ring operates on three core principles:
3333
│ │ Ring Marketplace │ │
3434
│ │ ┌──────────────────────┐ ┌──────────────────────┐ │ │
3535
│ │ │ ring-default │ │ ring-dev-team │ │ │
36-
│ │ │ Skills(27) Agents(5) │ │ Skills(9) Agents(9) │ │ │
37-
│ │ │ Cmds(13) Hooks/Lib │ │ Cmds(5) │ │ │
36+
│ │ │ Skills(24) Agents(7) │ │ Skills(9) Agents(9) │ │ │
37+
│ │ │ Cmds(12) Hooks/Lib │ │ Cmds(5) │ │ │
3838
│ │ └──────────────────────┘ └──────────────────────┘ │ │
3939
│ │ ┌──────────────────────┐ ┌──────────────────────┐ │ │
4040
│ │ │ ring-pm-team │ │ ring-tw-team │ │ │
@@ -72,7 +72,7 @@ ring/ # Monorepo root
7272

7373
| Plugin | Description | Components |
7474
|--------|-------------|------------|
75-
| **ring-default** | Core skills library | 27 skills, 5 agents, 13 commands |
75+
| **ring-default** | Core skills library | 24 skills, 7 agents, 12 commands |
7676
| **ring-dev-team** | Developer agents | 9 skills, 9 agents, 5 commands |
7777
| **ring-finops-team** | FinOps regulatory compliance | 6 skills, 2 agents |
7878
| **ring-pm-team** | Product planning workflows | 10 skills, 3 agents, 2 commands |
@@ -110,6 +110,8 @@ default/agents/
110110
├── ring:code-reviewer.md # Foundation review (architecture, patterns)
111111
├── ring:business-logic-reviewer.md # Correctness review (requirements, edge cases)
112112
├── ring:security-reviewer.md # Safety review (OWASP, auth, validation)
113+
├── ring:test-reviewer.md # Test coverage and quality review
114+
├── ring:nil-safety-reviewer.md # Null/nil safety analysis
113115
├── ring:write-plan.md # Implementation planning
114116
└── ring:codebase-explorer.md # Deep architecture analysis (Opus)
115117
```
@@ -671,23 +673,23 @@ Ring's architecture is designed for:
671673
| Component | Count | Location |
672674
|-----------|-------|----------|
673675
| Active Plugins | 5 | All plugin directories |
674-
| Skills (ring-default) | 27 | `default/skills/` |
676+
| Skills (ring-default) | 24 | `default/skills/` |
675677
| Skills (ring-dev-team) | 9 | `dev-team/skills/` |
676678
| Skills (ring-finops-team) | 6 | `finops-team/skills/` |
677679
| Skills (ring-pm-team) | 10 | `pm-team/skills/` |
678680
| Skills (ring-tw-team) | 7 | `tw-team/skills/` |
679-
| **Total Skills** | **59** | **All plugins** |
680-
| Agents (ring-default) | 5 | `default/agents/` |
681+
| **Total Skills** | **56** | **All plugins** |
682+
| Agents (ring-default) | 7 | `default/agents/` |
681683
| Agents (ring-dev-team) | 9 | `dev-team/agents/` |
682684
| Agents (ring-finops-team) | 2 | `finops-team/agents/` |
683685
| Agents (ring-pm-team) | 3 | `pm-team/agents/` |
684686
| Agents (ring-tw-team) | 3 | `tw-team/agents/` |
685-
| **Total Agents** | **22** | **All plugins** |
686-
| Commands (ring-default) | 13 | `default/commands/` |
687+
| **Total Agents** | **24** | **All plugins** |
688+
| Commands (ring-default) | 12 | `default/commands/` |
687689
| Commands (ring-dev-team) | 5 | `dev-team/commands/` |
688690
| Commands (ring-pm-team) | 2 | `pm-team/commands/` |
689691
| Commands (ring-tw-team) | 3 | `tw-team/commands/` |
690-
| **Total Commands** | **23** | **All plugins** |
692+
| **Total Commands** | **22** | **All plugins** |
691693
| Hooks | Per plugin | `{plugin}/hooks/` |
692694

693695
The system achieves these goals through clear component separation, structured workflows, automatic context management, and a modular marketplace architecture, creating a robust foundation for AI-assisted software development.

CLAUDE.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ When content is reused across multiple skills within a plugin:
197197
| [Key Workflows](#key-workflows) | Quick reference + [full docs](docs/WORKFLOWS.md) |
198198
| [Agent Output Schemas](#agent-output-schema-archetypes) | Schema summary + [full docs](docs/AGENT_DESIGN.md) |
199199
| [Compliance Rules](#compliance-rules) | TDD, Review, Commit rules |
200-
| [Standards-Agent Synchronization](#standards-agent-synchronization) | Standards ↔ Agent mapping |
200+
| [Standards-Agent Synchronization](#5-standards-agent-synchronization-always-check) | Standards ↔ Agent mapping |
201201
| [Documentation Sync](#documentation-sync-checklist) | Files to update |
202202

203203
---
@@ -438,7 +438,7 @@ The architecture uses markdown-based skill definitions with YAML frontmatter, au
438438

439439
## Installation
440440

441-
See [README.md](README.md#installation) or [docs/platforms/](docs/platforms/) for detailed installation instructions.
441+
See [README.md](README.md#installation) for detailed installation instructions.
442442

443443
**Quick install:** `curl -fsSL https://raw.githubusercontent.com/lerianstudio/ring/main/install-ring.sh | bash`
444444

@@ -450,7 +450,7 @@ See [README.md](README.md#installation) or [docs/platforms/](docs/platforms/) fo
450450

451451
| Plugin | Path | Contents |
452452
|--------|------|----------|
453-
| ring-default | `default/` | 24 skills, 7 agents, 10 commands |
453+
| ring-default | `default/` | 24 skills, 7 agents, 12 commands |
454454
| ring-dev-team | `dev-team/` | 9 skills, 9 agents, 5 commands |
455455
| ring-pm-team | `pm-team/` | 10 skills, 3 agents, 2 commands |
456456
| ring-finops-team | `finops-team/` | 6 skills, 2 agents |
@@ -586,7 +586,7 @@ The system loads at SessionStart (from `default/` plugin):
586586
- Repository: Monorepo marketplace with multiple plugin collections
587587
- Active plugins: 5 (`ring-default`, `ring-dev-team`, `ring-pm-team`, `ring-finops-team`, `ring-tw-team`)
588588
- Plugin versions: See `.claude-plugin/marketplace.json`
589-
- Core plugin: `default/` (24 skills, 7 agents, 10 commands)
589+
- Core plugin: `default/` (24 skills, 7 agents, 12 commands)
590590
- Developer agents: `dev-team/` (9 skills, 9 agents, 5 commands)
591591
- Product planning: `pm-team/` (10 skills, 3 agents, 2 commands)
592592
- FinOps regulatory: `finops-team/` (6 skills, 2 agents)

MANUAL.md

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Ring Marketplace Manual
22

3-
Quick reference guide for the Ring skills library and workflow system. This monorepo provides 5 plugins with 59 skills, 22 agents, and 23 slash commands for enforcing proven software engineering practices across the entire software delivery value chain.
3+
Quick reference guide for the Ring skills library and workflow system. This monorepo provides 5 plugins with 56 skills, 24 agents, and 22 slash commands for enforcing proven software engineering practices across the entire software delivery value chain.
44

55
---
66

@@ -13,9 +13,9 @@ Quick reference guide for the Ring skills library and workflow system. This mono
1313
│ │
1414
│ ┌───────────────┐ ┌───────────────┐ ┌───────────────┐ ┌───────────────┐ │
1515
│ │ ring-default │ │ ring-dev-team │ │ ring-pm-team │ │ring-finops- │ │
16-
│ │ Skills(27) │ │ Skills(9) │ │ Skills(10) │ │ team │ │
17-
│ │ Agents(5) │ │ Agents(9) │ │ Agents(3) │ │ Skills(6) │ │
18-
│ │ Cmds(13) │ │ Cmds(5) │ │ Cmds(2) │ │ Agents(2) │ │
16+
│ │ Skills(24) │ │ Skills(9) │ │ Skills(10) │ │ team │ │
17+
│ │ Agents(7) │ │ Agents(9) │ │ Agents(3) │ │ Skills(6) │ │
18+
│ │ Cmds(12) │ │ Cmds(5) │ │ Cmds(2) │ │ Agents(2) │ │
1919
│ └───────────────┘ └───────────────┘ └───────────────┘ └───────────────┘ │
2020
│ ┌───────────────┐ │
2121
│ │ ring-tw-team │ │
@@ -84,6 +84,8 @@ Commands are invoked directly: `/command-name`.
8484
|---------|----------|---------|
8585
| `/ring:brainstorm [topic]` | Interactive design refinement before coding | `/ring:brainstorm user-authentication` |
8686
| `/ring:explore-codebase [path]` | Autonomous two-phase codebase exploration | `/ring:explore-codebase payment/` |
87+
| `/ring:interview-me [topic]` | Proactive requirements gathering interview | `/ring:interview-me auth-system` |
88+
| `/ring:release-guide` | Generate step-by-step release instructions | `/ring:release-guide` |
8789
| `/ring:pre-dev-feature [name]` | Plan simple features (<2 days) – 3 gates | `/ring:pre-dev-feature logout-button` |
8890
| `/ring:pre-dev-full [name]` | Plan complex features (≥2 days) – 8 gates | `/ring:pre-dev-full payment-system` |
8991
| `/ring:worktree [branch-name]` | Create isolated git workspace | `/ring:worktree auth-system` |
@@ -127,7 +129,7 @@ Commands are invoked directly: `/command-name`.
127129

128130
## 💡 About Skills
129131

130-
Skills (59) are workflows that Claude Code invokes automatically when it detects they're applicable. They handle testing, debugging, verification, planning, and code review enforcement. You don't call them directly – Claude Code uses them internally to enforce best practices.
132+
Skills (56) are workflows that Claude Code invokes automatically when it detects they're applicable. They handle testing, debugging, verification, planning, and code review enforcement. You don't call them directly – Claude Code uses them internally to enforce best practices.
131133

132134
Examples: ring:test-driven-development, ring:systematic-debugging, ring:requesting-code-review, verification-before-completion, etc.
133135

@@ -157,15 +159,17 @@ Invoke via `Task tool with subagent_type: "..."`.
157159

158160
### Code Review (ring-default)
159161

160-
**Always dispatch all 3 in parallel** (single message, 3 Task calls):
162+
**Always dispatch all 5 in parallel** (single message, 5 Task calls):
161163

162164
| Agent | Purpose | Model |
163165
|-------|---------|-------|
164166
| `ring:code-reviewer` | Architecture, patterns, maintainability | Opus |
165167
| `ring:business-logic-reviewer` | Domain correctness, edge cases, requirements | Opus |
166168
| `ring:security-reviewer` | Vulnerabilities, OWASP, auth, validation | Opus |
169+
| `ring:test-reviewer` | Test coverage, quality, and completeness | Opus |
170+
| `ring:nil-safety-reviewer` | Nil/null pointer safety analysis | Opus |
167171

168-
**Example:** Before merging, run all 3 parallel reviewers via `/ring:codereview src/`
172+
**Example:** Before merging, run all 5 parallel reviewers via `/ring:codereview src/`
169173

170174
### Planning & Analysis (ring-default)
171175

@@ -274,6 +278,8 @@ Runs in parallel:
274278
• ring:code-reviewer (Opus)
275279
• ring:business-logic-reviewer (Opus)
276280
• ring:security-reviewer (Opus)
281+
• ring:test-reviewer (Opus)
282+
• ring:nil-safety-reviewer (Opus)
277283
278284
Consolidated report with recommendations
279285
```
@@ -338,7 +344,7 @@ These enforce quality standards:
338344
### Session Startup
339345

340346
1. SessionStart hook runs automatically
341-
2. All 59 skills are auto-discovered and available
347+
2. All 56 skills are auto-discovered and available
342348
3. `ring:using-ring` workflow is activated (skill checking is now mandatory)
343349

344350
### Agent Dispatching

README.md

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Without Ring, AI assistants often:
1616
Ring solves this by:
1717
- **Enforcing proven workflows** - Test-driven development, systematic debugging, proper planning
1818
- **Providing 56 specialized skills** (24 core + 9 dev-team + 10 product planning + 6 FinOps regulatory + 7 technical writing)
19-
- **22 specialized agents** - 5 review/planning + 9 developer + 3 product research + 2 FinOps regulatory + 3 technical writing
19+
- **24 specialized agents** - 7 review/planning + 9 developer + 3 product research + 2 FinOps regulatory + 3 technical writing
2020
- **Automating skill discovery** - Skills load automatically at session start
2121
- **Preventing common failures** - Built-in anti-patterns and mandatory checklists
2222

@@ -26,6 +26,8 @@ Ring solves this by:
2626
- `ring:code-reviewer` - Foundation review (architecture, code quality, design patterns)
2727
- `ring:business-logic-reviewer` - Correctness review (domain logic, requirements, edge cases)
2828
- `ring:security-reviewer` - Safety review (vulnerabilities, OWASP, authentication)
29+
- `ring:test-reviewer` - Test quality review (coverage, edge cases, assertions, test anti-patterns)
30+
- `ring:nil-safety-reviewer` - Nil/null safety review (traces pointer risks, missing guards, panic paths)
2931
- `ring:write-plan` - Implementation planning agent
3032
- `ring:codebase-explorer` - Deep architecture analysis (Opus-powered, complements built-in Explore)
3133
- Use `/ring:codereview` command to orchestrate parallel review workflow
@@ -273,7 +275,7 @@ No "should work" → Only "does work" with proof
273275
**6-Gate Workflow Skills:**
274276
- `ring:dev-implementation` - Gate 0: TDD implementation
275277
- `ring:dev-devops` - Gate 1: DevOps setup (Docker, compose)
276-
- `ring:dev-ring:sre` - Gate 2: Observability setup
278+
- `ring:dev-sre` - Gate 2: Observability setup
277279
- `ring:dev-testing` - Gate 3: Test coverage
278280
- `ring:requesting-code-review` - Gate 4: Parallel code review (3 reviewers)
279281
- `ring:dev-validation` - Gate 5: User approval
@@ -328,6 +330,8 @@ Ring provides 22 slash commands across 5 plugins for common workflows.
328330
- `/ring:execute-plan [path]` - Execute plan in batches with review checkpoints
329331
- `/ring:lint [path]` - Run lint checks and dispatch parallel agents to fix all issues
330332
- `/ring:explore-codebase [path]` - Deep codebase exploration using Opus-powered agent
333+
- `/ring:interview-me [topic]` - Proactive requirements gathering through structured user interview
334+
- `/ring:release-guide` - Generate Ops Update Guide from git diff between two refs
331335
- `/ring:create-handoff [name]` - Create handoff document for session continuity
332336
- `/ring:resume-handoff [path]` - Resume work from a previous handoff
333337

@@ -428,20 +432,24 @@ ring/ # Monorepo root
428432
│ │ ├── hooks.json # Hook configuration
429433
│ │ ├── session-start.sh # Loads skills at startup
430434
│ │ └── generate-skills-ref.py # Auto-generates quick reference
431-
│ ├── agents/ # 5 specialized agents
435+
│ ├── agents/ # 7 specialized agents
432436
│ │ ├── ring:code-reviewer.md # Foundation review (parallel)
433437
│ │ ├── ring:business-logic-reviewer.md # Correctness review (parallel)
434438
│ │ ├── ring:security-reviewer.md # Safety review (parallel)
439+
│ │ ├── ring:test-reviewer.md # Test quality review (parallel)
440+
│ │ ├── ring:nil-safety-reviewer.md # Nil/null safety review (parallel)
435441
│ │ ├── ring:write-plan.md # Implementation planning
436442
│ │ └── ring:codebase-explorer.md # Deep architecture analysis (Opus)
437443
│ └── docs/ # Documentation
438444
├── dev-team/ # Developer Agents plugin (ring-dev-team)
439-
│ └── agents/ # 7 specialized developer agents
445+
│ └── agents/ # 9 specialized developer agents
440446
│ ├── ring:backend-engineer-golang.md # Go backend specialist
441447
│ ├── ring:backend-engineer-typescript.md # TypeScript/Node.js backend specialist
442448
│ ├── ring:devops-engineer.md # DevOps infrastructure
443449
│ ├── frontend-bff-engineer-typescript.md # BFF & React/Next.js frontend specialist
444450
│ ├── ring:frontend-designer.md # Visual design specialist
451+
│ ├── ring:frontend-engineer.md # Senior Frontend Engineer (React/Next.js)
452+
│ ├── prompt-quality-reviewer.md # Agent Quality Analyst
445453
│ ├── ring:qa-analyst.md # Quality assurance
446454
│ └── sre.md # Site reliability engineer
447455
├── pm-team/ # Product Planning plugin (ring-pm-team)

0 commit comments

Comments
 (0)