Merge pull request #92 from LibreCodeCoop/fix/csll-retencao-fallback

fix: fallback tpRetPisCofins when CSLL retention is zero

Author: vitormattos

Http/Controllers/InvoiceController.php

@@ -1104,6 +1104,14 @@ protected function federalPayloadValues(float $invoiceAmount): array
     {
         $situacaoTributaria = $this->normalizedFederalSelectValue(setting('nfse.federal_piscofins_situacao_tributaria', ''));
         $tipoRetencao = $this->normalizedFederalSelectValue(setting('nfse.federal_piscofins_tipo_retencao', ''));
+        $valorCsllRetencao = $this->calculateFederalRetentionValue($invoiceAmount, 'federal_valor_csll');
+
+        if (in_array($tipoRetencao, ['4', '5', '6'], true) && $valorCsllRetencao === '') {
+            // Gateway currently rejects tpRetPisCofins != 0 without vRetCSLL.
+            // When configured CSLL retention is zero, fallback avoids invalid payloads.
+            $tipoRetencao = '0';
+        }
+
         $isSimplesNacionalOptant = $this->normalizedOpcaoSimplesNacional() === 2;
 
         $totalTributosPercentualFederal = $this->normalizedFederalDecimal(setting($isSimplesNacionalOptant ? 'nfse.tributos_fed_sn' : 'nfse.tributos_fed_p', ''));
@@ -1160,7 +1168,7 @@ protected function federalPayloadValues(float $invoiceAmount): array
                 : '',
             'federalValorIrrf' => $this->calculateFederalRetentionValue($invoiceAmount, 'federal_valor_irrf'),
             'federalValorCsll' => $tipoRetencao !== '0'
-                ? $this->calculateFederalRetentionValue($invoiceAmount, 'federal_valor_csll')
+                ? $valorCsllRetencao
                 : '',
             // Produção restrita currently rejects vRetCP (RNG6110), so keep CP as UI/config only.
             'federalValorCp' => '',

tests/Unit/Http/Controllers/InvoiceControllerTest.php

@@ -529,6 +529,66 @@ public function testRuntimeXmlBuilderStartsInfDpsWithTpAmbBeforeMunicipalityFiel
             self::assertStringNotContainsString('<cMun>3303302</cMun>', $normalizedXml);
         }
 
+        public function testEmitFallsBackToNoRetentionWhenTypeRequiresCsllButConfiguredValueIsZero(): void
+        {
+            ControllerIsolationState::$settings['nfse.federal_piscofins_tipo_retencao'] = '4';
+            ControllerIsolationState::$settings['nfse.federal_valor_csll'] = '0.00';
+
+            $invoice = InvoiceControllerIsolationState::makeInvoice(
+                id: 204,
+                amount: 1000.00,
+                items: [
+                    ['name' => 'Servico fallback retencao'],
+                ],
+            );
+
+            $client = new class () implements NfseClientInterface {
+                public ?DpsData $capturedDps = null;
+
+                public function emit(DpsData $dps): ReceiptData
+                {
+                    $this->capturedDps = $dps;
+
+                    return new ReceiptData(
+                        nfseNumber: 'NF-204',
+                        chaveAcesso: 'CHAVE-204',
+                        dataEmissao: '2026-04-03T12:00:00-03:00',
+                    );
+                }
+
+                public function query(string $chaveAcesso): ReceiptData
+                {
+                    throw new \BadMethodCallException('Not used in this test.');
+                }
+
+                public function cancel(string $chaveAcesso, string $motivo): bool
+                {
+                    throw new \BadMethodCallException('Not used in this test.');
+                }
+            };
+
+            $controller = new class ($client) extends InvoiceController {
+                public function __construct(private readonly NfseClientInterface $client)
+                {
+                }
+
+                protected function makeClient(bool $sandboxMode): NfseClientInterface
+                {
+                    return $this->client;
+                }
+
+                protected function hasCertificateSecret(string $cnpj): bool
+                {
+                    return true;
+                }
+            };
+
+            $controller->emit($invoice);
+
+            self::assertSame('0', $client->capturedDps?->federalPiscofinsTipoRetencao);
+            self::assertSame('', $client->capturedDps?->federalValorCsll);
+        }
+
         public function testEmitPrefersDefaultCompanyServiceOverLegacyFiscalSettings(): void
         {
             $invoice = InvoiceControllerIsolationState::makeInvoice(