fix: run lint

csanjuanc · csanjuanc · commit 06cf16ca4317 · 2021-09-24T13:51:36.000-03:00
diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php
@@ -27,33 +27,27 @@ public function getConfigTreeBuilder()
         $rootNode
             ->useAttributeAsKey('name')
             ->prototype('array')
-                ->useAttributeAsKey('field')
-                ->prototype('array')
-                    ->children()
-                        ->booleanNode('enabled')
-                            ->defaultTrue()
-                        ->end()
-
-                        ->scalarNode('type')
-                            ->isRequired()
-                        ->end()
-
-                        ->variableNode('options')
-                        ->end()
-
-                        ->variableNode('transformer')
-                        ->end()
-
-                        ->variableNode('validation')
-                        ->end()
-
-                        ->scalarNode('data_provider')
-                        ->end()
-
-                        ->scalarNode('help_message_provider')
-                        ->end()
-                    ->end()
-                ->end()
+            ->useAttributeAsKey('field')
+            ->prototype('array')
+            ->children()
+            ->booleanNode('enabled')
+            ->defaultTrue()
+            ->end()
+            ->scalarNode('type')
+            ->isRequired()
+            ->end()
+            ->variableNode('options')
+            ->end()
+            ->variableNode('transformer')
+            ->end()
+            ->variableNode('validation')
+            ->end()
+            ->scalarNode('data_provider')
+            ->end()
+            ->scalarNode('help_message_provider')
+            ->end()
+            ->end()
+            ->end()
             ->end();
 
         return $treeBuilder;
diff --git a/src/Form/FormFactory.php b/src/Form/FormFactory.php
@@ -82,7 +82,7 @@ public function addEventSubscriber($formName, EventSubscriberInterface $eventSub
 
     /**
      * @param string $key     The key of the Form in the form configuration
-     * @param mixed  $data
+     * @param array  $data
      * @param array  $options
      * @param string $name    An name for the form. If empty, the key will be used
      *
@@ -242,7 +242,7 @@ public function loadHelpMessageProvider($alias)
      */
     public function getConfiguration($name = null)
     {
-        if (null === $name) {
+        if ($name === null) {
             return $this->configuration;
         }
 
diff --git a/tests/Form/FormFactoryTest.php b/tests/Form/FormFactoryTest.php
@@ -7,14 +7,15 @@
 use Linio\DynamicFormBundle\Exception\NonExistentFormException;
 use Linio\DynamicFormBundle\Form\FormFactory;
 use Linio\DynamicFormBundle\HelpMessageProvider;
+use PHPUnit\Framework\TestCase;
 use Prophecy\Prophecy\ObjectProphecy;
 use Symfony\Component\Form\DataTransformerInterface;
 use Symfony\Component\Form\Extension\Core\Type\FormType;
 use Symfony\Component\Form\FormBuilder;
 use Symfony\Component\Form\FormFactory as SymfonyFormFactory;
 use Symfony\Component\Validator\Constraints\IsTrue;
 
-class FormFactoryTest extends \PHPUnit_Framework_TestCase
+class FormFactoryTest extends TestCase
 {
     /**
      * @var ObjectProphecy
@@ -31,11 +32,10 @@ class FormFactoryTest extends \PHPUnit_Framework_TestCase
      */
     protected $formFactoryMock;
 
-    /**
-     * @expectedException \Linio\DynamicFormBundle\Exception\NonExistentFormException
-     */
     public function testIsThrowingExceptionWhenCreatingAnInexistentForm(): void
     {
+        $this->expectException(NonExistentFormException::class);
+
         $this->formFactory->setConfiguration(['foo' => []]);
         $this->formFactory->createForm('bar');
     }
diff --git a/tests/FormlyMapper/FormlyField/ChoiceFieldTest.php b/tests/FormlyMapper/FormlyField/ChoiceFieldTest.php
@@ -5,8 +5,9 @@
 namespace Linio\DynamicFormBundle\Tests\FormlyMapper\FormlyField;
 
 use Linio\DynamicFormBundle\FormlyMapper\FormlyField\ChoiceField;
+use PHPUnit\Framework\TestCase;
 
-class ChoiceFieldTest extends \PHPUnit_Framework_TestCase
+class ChoiceFieldTest extends TestCase
 {
     /**
      * @var ChoiceField
diff --git a/tests/FormlyMapper/FormlyField/DateFieldTest.php b/tests/FormlyMapper/FormlyField/DateFieldTest.php
@@ -5,8 +5,9 @@
 namespace Linio\DynamicFormBundle\Tests\FormlyMapper\FormlyField;
 
 use Linio\DynamicFormBundle\FormlyMapper\FormlyField\DateField;
+use PHPUnit\Framework\TestCase;
 
-class DateFieldTest extends \PHPUnit_Framework_TestCase
+class DateFieldTest extends TestCase
 {
     /**
      * @var DateField
diff --git a/tests/FormlyMapper/FormlyField/EmailFieldTest.php b/tests/FormlyMapper/FormlyField/EmailFieldTest.php
@@ -5,8 +5,9 @@
 namespace Linio\DynamicFormBundle\Tests\FormlyMapper\FormlyField;
 
 use Linio\DynamicFormBundle\FormlyMapper\FormlyField\EmailField;
+use PHPUnit\Framework\TestCase;
 
-class EmailFieldTest extends \PHPUnit_Framework_TestCase
+class EmailFieldTest extends TestCase
 {
     /**
      * @var EmailField
diff --git a/tests/FormlyMapper/FormlyField/EntityFieldTest.php b/tests/FormlyMapper/FormlyField/EntityFieldTest.php
@@ -5,8 +5,9 @@
 namespace Linio\DynamicFormBundle\Tests\FormlyMapper\FormlyField;
 
 use Linio\DynamicFormBundle\FormlyMapper\FormlyField\EntityField;
+use PHPUnit\Framework\TestCase;
 
-class EntityFieldTest extends \PHPUnit_Framework_TestCase
+class EntityFieldTest extends TestCase
 {
     /**
      * @var EntityField
diff --git a/tests/FormlyMapper/FormlyField/FileFieldTest.php b/tests/FormlyMapper/FormlyField/FileFieldTest.php
@@ -5,8 +5,9 @@
 namespace Linio\DynamicFormBundle\Tests\FormlyMapper\FormlyField;
 
 use Linio\DynamicFormBundle\FormlyMapper\FormlyField\FileField;
+use PHPUnit\Framework\TestCase;
 
-class FileFieldTest extends \PHPUnit_Framework_TestCase
+class FileFieldTest extends TestCase
 {
     /**
      * @var FileField
diff --git a/tests/FormlyMapper/FormlyField/FormlyFieldFactoryTest.php b/tests/FormlyMapper/FormlyField/FormlyFieldFactoryTest.php
@@ -7,8 +7,9 @@
 use Linio\DynamicFormBundle\FormlyMapper\FormlyField\DefaultField;
 use Linio\DynamicFormBundle\FormlyMapper\FormlyField\FormlyFieldFactory;
 use Linio\DynamicFormBundle\FormlyMapper\FormlyField\NumberField;
+use PHPUnit\Framework\TestCase;
 
-class FormlyFieldFactoryTest extends \PHPUnit_Framework_TestCase
+class FormlyFieldFactoryTest extends TestCase
 {
     public function testIsHasTheFormlyField(): void
     {
diff --git a/tests/FormlyMapper/FormlyField/HiddenFieldTest.php b/tests/FormlyMapper/FormlyField/HiddenFieldTest.php
@@ -5,8 +5,9 @@
 namespace Linio\DynamicFormBundle\Tests\FormlyMapper\FormlyField;
 
 use Linio\DynamicFormBundle\FormlyMapper\FormlyField\HiddenField;
+use PHPUnit\Framework\TestCase;
 
-class HiddenFieldTest extends \PHPUnit_Framework_TestCase
+class HiddenFieldTest extends TestCase
 {
     /**
      * @var HiddenField
diff --git a/tests/FormlyMapper/FormlyField/NumberFieldTest.php b/tests/FormlyMapper/FormlyField/NumberFieldTest.php
@@ -5,8 +5,9 @@
 namespace Linio\DynamicFormBundle\Tests\FormlyMapper\FormlyField;
 
 use Linio\DynamicFormBundle\FormlyMapper\FormlyField\NumberField;
+use PHPUnit\Framework\TestCase;
 
-class NumberFieldTest extends \PHPUnit_Framework_TestCase
+class NumberFieldTest extends TestCase
 {
     /**
      * @var NumberField
diff --git a/tests/FormlyMapper/FormlyField/PasswordFieldTest.php b/tests/FormlyMapper/FormlyField/PasswordFieldTest.php
@@ -5,8 +5,9 @@
 namespace Linio\DynamicFormBundle\Tests\FormlyMapper\FormlyField;
 
 use Linio\DynamicFormBundle\FormlyMapper\FormlyField\PasswordField;
+use PHPUnit\Framework\TestCase;
 
-class PasswordFieldTest extends \PHPUnit_Framework_TestCase
+class PasswordFieldTest extends TestCase
 {
     /**
      * @var PasswordField
diff --git a/tests/FormlyMapper/FormlyField/SearchFieldTest.php b/tests/FormlyMapper/FormlyField/SearchFieldTest.php
@@ -5,8 +5,9 @@
 namespace Linio\DynamicFormBundle\Tests\FormlyMapper\FormlyField;
 
 use Linio\DynamicFormBundle\FormlyMapper\FormlyField\SearchField;
+use PHPUnit\Framework\TestCase;
 
-class SearchFieldTest extends \PHPUnit_Framework_TestCase
+class SearchFieldTest extends TestCase
 {
     /**
      * @var SearchField
diff --git a/tests/FormlyMapper/FormlyField/TextFieldTest.php b/tests/FormlyMapper/FormlyField/TextFieldTest.php
@@ -5,8 +5,9 @@
 namespace Linio\DynamicFormBundle\Tests\FormlyMapper\FormlyField;
 
 use Linio\DynamicFormBundle\FormlyMapper\FormlyField\TextField;
+use PHPUnit\Framework\TestCase;
 
-class TextFieldTest extends \PHPUnit_Framework_TestCase
+class TextFieldTest extends TestCase
 {
     /**
      * @var TextField
diff --git a/tests/FormlyMapper/FormlyField/TextareaFieldTest.php b/tests/FormlyMapper/FormlyField/TextareaFieldTest.php
@@ -5,8 +5,9 @@
 namespace Linio\DynamicFormBundle\Tests\FormlyMapper\FormlyField;
 
 use Linio\DynamicFormBundle\FormlyMapper\FormlyField\TextareaField;
+use PHPUnit\Framework\TestCase;
 
-class TextareaFieldTest extends \PHPUnit_Framework_TestCase
+class TextareaFieldTest extends TestCase
 {
     /**
      * @var TextareaField
diff --git a/tests/FormlyMapper/FormlyField/TimeFieldTest.php b/tests/FormlyMapper/FormlyField/TimeFieldTest.php
@@ -5,8 +5,9 @@
 namespace Linio\DynamicFormBundle\Tests\FormlyMapper\FormlyField;
 
 use Linio\DynamicFormBundle\FormlyMapper\FormlyField\TimeField;
+use PHPUnit\Framework\TestCase;
 
-class TimeFieldTest extends \PHPUnit_Framework_TestCase
+class TimeFieldTest extends TestCase
 {
     /**
      * @var TimeField
diff --git a/tests/FormlyMapper/FormlyField/UrlFieldTest.php b/tests/FormlyMapper/FormlyField/UrlFieldTest.php
@@ -5,8 +5,9 @@
 namespace Linio\DynamicFormBundle\Tests\FormlyMapper\FormlyField;
 
 use Linio\DynamicFormBundle\FormlyMapper\FormlyField\UrlField;
+use PHPUnit\Framework\TestCase;
 
-class UrlFieldTest extends \PHPUnit_Framework_TestCase
+class UrlFieldTest extends TestCase
 {
     /**
      * @var UrlField
diff --git a/tests/FormlyMapper/FormlyMapperTest.php b/tests/FormlyMapper/FormlyMapperTest.php
@@ -4,15 +4,17 @@
 
 namespace Linio\DynamicFormBundle\Tests\FormlyMapper;
 
+use Linio\DynamicFormBundle\Exception\FormlyMapperException;
 use Linio\DynamicFormBundle\Exception\NonExistentFormException;
 use Linio\DynamicFormBundle\Form\FormFactory;
 use Linio\DynamicFormBundle\FormlyMapper\FormlyField;
 use Linio\DynamicFormBundle\FormlyMapper\FormlyField\FormlyFieldFactory;
 use Linio\DynamicFormBundle\FormlyMapper\FormlyMapper;
+use PHPUnit\Framework\TestCase;
 use Prophecy\Prophecy\ObjectProphecy;
 use Symfony\Component\Security\Csrf\CsrfToken;
 
-class FormlyMapperTest extends \PHPUnit_Framework_TestCase
+class FormlyMapperTest extends TestCase
 {
     /**
      * @var CsrfToken
@@ -113,11 +115,10 @@ public function testIsMappingCorrectly(): void
         $this->assertEquals($expected, $actual);
     }
 
-    /**
-     * @expectedException \Linio\DynamicFormBundle\Exception\FormlyMapperException
-     */
     public function testIsThrowingNonExistentFormException(): void
     {
+        $this->expectException(FormlyMapperException::class);
+
         $formName = 'foo';
 
         $this->formFactoryMock->getConfiguration($formName)

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ public function addEventSubscriber($formName, EventSubscriberInterface $eventSub`
`82`	`82`
`83`	`83`	`/**`
`84`	`84`	`* @param string $key The key of the Form in the form configuration`
`85`		`- * @param mixed $data`
	`85`	`+ * @param array $data`
`86`	`86`	`* @param array $options`
`87`	`87`	`* @param string $name An name for the form. If empty, the key will be used`
`88`	`88`	`*`
`@@ -242,7 +242,7 @@ public function loadHelpMessageProvider($alias)`
`242`	`242`	`*/`
`243`	`243`	`public function getConfiguration($name = null)`
`244`	`244`	`{`
`245`		`- if (null === $name) {`
	`245`	`+ if ($name === null) {`
`246`	`246`	`return $this->configuration;`
`247`	`247`	`}`
`248`	`248`
Original file line number	Diff line number	Diff line change
`@@ -5,8 +5,9 @@`
`5`	`5`	`namespace Linio\DynamicFormBundle\Tests\FormlyMapper\FormlyField;`
`6`	`6`
`7`	`7`	`use Linio\DynamicFormBundle\FormlyMapper\FormlyField\ChoiceField;`
	`8`	`+use PHPUnit\Framework\TestCase;`
`8`	`9`
`9`		`-class ChoiceFieldTest extends \PHPUnit_Framework_TestCase`
	`10`	`+class ChoiceFieldTest extends TestCase`
`10`	`11`	`{`
`11`	`12`	`/**`
`12`	`13`	`* @var ChoiceField`
Original file line number	Diff line number	Diff line change
`@@ -7,8 +7,9 @@`
`7`	`7`	`use Linio\DynamicFormBundle\FormlyMapper\FormlyField\DefaultField;`
`8`	`8`	`use Linio\DynamicFormBundle\FormlyMapper\FormlyField\FormlyFieldFactory;`
`9`	`9`	`use Linio\DynamicFormBundle\FormlyMapper\FormlyField\NumberField;`
	`10`	`+use PHPUnit\Framework\TestCase;`
`10`	`11`
`11`		`-class FormlyFieldFactoryTest extends \PHPUnit_Framework_TestCase`
	`12`	`+class FormlyFieldFactoryTest extends TestCase`
`12`	`13`	`{`
`13`	`14`	`public function testIsHasTheFormlyField(): void`
`14`	`15`	`{`