Controller activates on forming multiblock - #8
Merged
Conversation
Contributor
Author
|
Manual testing, that I've done.
Still didn't find "tubelib", so can't test interaction. |
CodingMantisUA
changed the title
LunaSquee
reviewed
Jun 7, 2026
|
|
||
| local volume = calculate_volume(dimensions) | ||
| swap_node(pos, node, "multifurnace:controller_active") | ||
| def = core.registered_nodes["multifurnace:controller_active"] |
Owner
There was a problem hiding this comment.
the API was supposed to be able to handle arbitrary multifurnace registrations, you should store the different states in the node definition and access them from there if possible.
Owner
|
The tubelib mod is from techpack by joe7575 |
Contributor
Author
|
Made controller provide state definitions. |
CodingMantisUA
force-pushed
the
active_controller
branch
from
June 8, 2026 19:43
a0a124f to
934209d
Compare
Owner
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! Not sure if you accept PR-s, so submitting this for review as proof of concept.
For me it's very annoying that meltern does not show at a glance when it is formed, decided to change it and boy-o-boy was it a rabbit hole.
Haven't done extensive testing yet. Works at a glance.
Didn't find a "tubelib" mod, only "tubelib2". Couldn't test those changes. Maybe that dependency should be removed altogether?
If concept is OK, can make any required changes, extensive testing and code clean-up.
Thanks!