VDR: Accumulate draws from secondaries

Currently each primary in CmdExecuteCommands executes its corresponding
command buffer from the secondary context. In practice this means that
each secondary is essentially run in isolation from the other
secondaries which causes incorrect renderings.

This commit addresses this by progressively accumulating command buffer
from each secondary so that previous secondaries are send for execution
along with subsequent ones from the same execute commands.

Author: panos-lunarg

framework/decode/vulkan_replay_dump_resources.cpp

@@ -2208,7 +2208,8 @@ void VulkanReplayDumpResourcesBase::OverrideCmdExecuteCommands(const ApiCallInfo
 
         if (dc_primary_context->ShouldHandleExecuteCommands(call_info.index))
         {
-            uint32_t finalized_primaries = 0;
+            uint32_t                     finalized_primaries = 0;
+            std::vector<VkCommandBuffer> accumulated_secondaries_command_buffers;
             for (uint32_t i = 0; i < commandBufferCount; ++i)
             {
                 const std::vector<std::shared_ptr<DrawCallsDumpingContext>> dc_secondary_contexts =
@@ -2217,19 +2218,29 @@ void VulkanReplayDumpResourcesBase::OverrideCmdExecuteCommands(const ApiCallInfo
                 {
                     for (auto dc_secondary_context : dc_secondary_contexts)
                     {
-                        const std::vector<VkCommandBuffer>& secondarys_command_buffers =
+                        const std::vector<VkCommandBuffer>& secondaries_command_buffers =
                             dc_secondary_context->GetCommandBuffers();
-
-                        GFXRECON_ASSERT(secondarys_command_buffers.size() <=
+                        GFXRECON_ASSERT(secondaries_command_buffers.size() <=
                                         primary_last - (primary_first + finalized_primaries));
-                        for (size_t scb = 0; scb < secondarys_command_buffers.size(); ++scb)
+                        for (size_t scb = 0; scb < secondaries_command_buffers.size(); ++scb)
                         {
-                            func(*(primary_first + finalized_primaries), 1, &secondarys_command_buffers[scb]);
+                            // Each primary should execute the command buffer from the previous
+                            // secondary contexts as well
+                            func(*(primary_first + finalized_primaries),
+                                 accumulated_secondaries_command_buffers.size(),
+                                 accumulated_secondaries_command_buffers.data());
+
+                            func(*(primary_first + finalized_primaries), 1, &secondaries_command_buffers[scb]);
                             dc_primary_context->FinalizeCommandBuffer();
                             dc_primary_context->MergeRenderPasses(*dc_secondary_context);
                             ++finalized_primaries;
                         }
 
+                        // Keep accumulating the command buffer from all secondary contexts
+                        accumulated_secondaries_command_buffers.insert(accumulated_secondaries_command_buffers.end(),
+                                                                       secondaries_command_buffers.begin(),
+                                                                       secondaries_command_buffers.end());
+
                         // All primaries have been finalized. Nothing else to do
                         if (finalized_primaries == primary_last - primary_first)
                         {