Simplify lifecycle status updates

Author: Distortions81

constants/consts.go

@@ -4,7 +4,7 @@ import "time"
 
 const (
 	ProgName           = "ChatWire"
-	Version            = "2704-04.20.2026-0108a" // build-mm.dd.yyyy-hhmmsuffix
+	Version            = "2705-04.21.2026-1305a" // build-mm.dd.yyyy-hhmmsuffix
 	CWEpoch            = 1653239822390688174 //Never change this
 	SeenDivisor        = 60
 	SeenEpoch          = 1546326000

fact/operation_status.go

@@ -17,7 +17,6 @@ import (
 const (
 	operationAnnounceDelay    = 3 * time.Second
 	operationProgressThrottle = 10 * time.Second
-	operationReminderInterval = 10 * time.Second
 	operationOptionalTTL      = 60 * time.Second
 )
 
@@ -131,13 +130,9 @@ func UpdateOperationProgressDelayed(token, title, description string, color int,
 func UpdateOperationProgressDelayedWithReminder(token, title, description, reminderDescription string, color int, delay time.Duration) {
 	title = strings.TrimSpace(title)
 	description = strings.TrimSpace(description)
-	reminderDescription = strings.TrimSpace(reminderDescription)
 	if token == "" || title == "" || description == "" {
 		return
 	}
-	if reminderDescription == "" {
-		reminderDescription = description
-	}
 	if delay <= 0 {
 		UpdateOperationProgress(token, title, description, color)
 		return
@@ -153,18 +148,10 @@ func UpdateOperationProgressDelayedWithReminder(token, title, description, remin
 	delayID := operationStatus.pendingDelayID
 	operationStatusLock.Unlock()
 
-	go func(tok, ttl, firstDesc, repeatDesc string, firstWait time.Duration, id uint64) {
-		wait := firstWait
-		desc := firstDesc
-		for {
-			time.Sleep(wait)
-			if !emitScheduledOperationProgress(tok, ttl, desc, color, id) {
-				return
-			}
-			desc = repeatDesc
-			wait = operationReminderInterval
-		}
-	}(token, title, description, reminderDescription, firstWait, delayID)
+	go func(tok, ttl, firstDesc string, firstWait time.Duration, id uint64) {
+		time.Sleep(firstWait)
+		_ = emitScheduledOperationProgress(tok, ttl, firstDesc, color, id)
+	}(token, title, description, firstWait, delayID)
 }
 
 func nextOptionalProgressDelay(startedAt time.Time, announced bool, delay time.Duration) time.Duration {

fact/operation_status_test.go

@@ -75,39 +75,6 @@ func TestNewDelayedProgressReplacesOlderPendingReminder(t *testing.T) {
 	}
 }
 
-func TestDelayedReminderUsesRepeatWordingAfterFirstEmission(t *testing.T) {
-	resetOperationStatusTestState()
-
-	token := BeginOperation("Starting Factorio.", "Starting Factorio.")
-	UpdateOperationProgressDelayedWithReminder(token, "Starting Factorio.", "Factorio is loading mods.", "Factorio is continuing to load mods.", 0, time.Hour)
-
-	operationStatusLock.Lock()
-	delayID := operationStatus.pendingDelayID
-	operationStatusLock.Unlock()
-
-	if !emitScheduledOperationProgress(token, "Starting Factorio.", "Factorio is loading mods.", 0, delayID) {
-		t.Fatal("expected first delayed reminder to be accepted")
-	}
-
-	operationStatusLock.Lock()
-	if operationStatus.description != "Factorio is loading mods." {
-		operationStatusLock.Unlock()
-		t.Fatalf("expected first emission to use initial wording, got %q", operationStatus.description)
-	}
-	operationStatus.lastProgressUpdateAt = time.Now().Add(-operationProgressThrottle - time.Millisecond)
-	operationStatusLock.Unlock()
-
-	if !emitScheduledOperationProgress(token, "Starting Factorio.", "Factorio is continuing to load mods.", 0, delayID) {
-		t.Fatal("expected repeat delayed reminder to be accepted")
-	}
-
-	operationStatusLock.Lock()
-	defer operationStatusLock.Unlock()
-	if operationStatus.description != "Factorio is continuing to load mods." {
-		t.Fatalf("expected repeat emission to use reminder wording, got %q", operationStatus.description)
-	}
-}
-
 func TestFinalizeOperationRejectsOlderPendingReminders(t *testing.T) {
 	resetOperationStatusTestState()
 

fact/status_messages.go

@@ -93,5 +93,5 @@ func StatusBringingServerOnline() string {
 }
 
 func StatusBringingServerOnlineStill() string {
-	return "Factorio is still bringing the server online."
+	return StatusBringingServerOnline()
 }